From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1BDDC8300C for ; Sun, 11 Jun 2023 23:36:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232492AbjFKXgm (ORCPT ); Sun, 11 Jun 2023 19:36:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230041AbjFKXgf (ORCPT ); Sun, 11 Jun 2023 19:36:35 -0400 Received: from mail-pg1-x549.google.com (mail-pg1-x549.google.com [IPv6:2607:f8b0:4864:20::549]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58061193 for ; Sun, 11 Jun 2023 16:36:34 -0700 (PDT) Received: by mail-pg1-x549.google.com with SMTP id 41be03b00d2f7-5488dccfbdfso2593846a12.2 for ; Sun, 11 Jun 2023 16:36:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686526594; x=1689118594; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=k9cwHrs21djZApS7zUbHblwlDRTI+1czCtHQubUC6Kg=; b=7xIkn6oyjG3Q7/kGPqSYyW4IIf90AkZn+Xz1ZYmfUMHQv28egJJNMUZ7HGg69SXPBq tkFBwo2YgooqkUvUTjyjL5B5+GdpvIJwlscTSXfJiHZlnKN0YzSOVPSU75LEtRaBiBDP v7qEpbZ8daH06a4DQlgEW6iIVI6FXiHOq7FvZFnPSSGlmISz99yhDjX0gH/g0OTZIY9C ir8/aQ1jM6AzGQes+rQMfrqn62rlJyv+ZqmglSy0wJD3LSpfqGnw2yoj2PtCSl2mf3Y8 91zGPGxHBYSsxSOWxwJ5SfHHbYoNsKAo/5DmjG7R3xiKCk42ckrzxa+G62EwZmhu8Hp2 x4wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686526594; x=1689118594; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=k9cwHrs21djZApS7zUbHblwlDRTI+1czCtHQubUC6Kg=; b=P7BCXdWsBUmW0aAuDO8y3m9PehEStgrDcWI/5TueiopK5D5yIWB4m5ylikjFoA9iaQ 8aUXQ9qMgo30I/lTd3b4cxb5WGWy4lu5hQ53qy3Aa/InKSJwNs/qf+WjNM5BQc3m8tty /jQ/Oz9JhGhdqlXc6OPnil+AmDPs5cehSaJvqFfbPKaftfeJT6g8KwVSnfNI6YPIKvjz 4rteVmncJk3B7We1Jnn1koP+5GduyN7WBkkHROk5vcWRA+Ss8+TL5qnv4ra8vQkiAY3R 3qn5T8bzam/WrTmAtSI6obyUGL+aalHf3R457eWVMtRbxV9KkvQ+X9J+RXGo1pPtwHAy /VtQ== X-Gm-Message-State: AC+VfDwnbDN+vmdmBxb6Z3EmmcsxZxtmBqOgswwa6dLD2/risI6Gp8G2 WAJIBnZHSgaF3WQR3Bg/vKnGPxFF7XYD X-Google-Smtp-Source: ACHHUZ40TT/qLzJOYNWxXVqlD3If2CWCua1Ha+mUvlN75NgOBRCCkKrrMpatRWEOlLRMv2oD0dcCEqHxTsbe X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:aca9:d7c7:ed17:e760]) (user=irogers job=sendgmr) by 2002:a65:66ca:0:b0:519:d08d:a4d5 with SMTP id c10-20020a6566ca000000b00519d08da4d5mr1003460pgw.6.1686526593620; Sun, 11 Jun 2023 16:36:33 -0700 (PDT) Date: Sun, 11 Jun 2023 16:36:07 -0700 In-Reply-To: <20230611233610.953456-1-irogers@google.com> Message-Id: <20230611233610.953456-2-irogers@google.com> Mime-Version: 1.0 References: <20230611233610.953456-1-irogers@google.com> X-Mailer: git-send-email 2.41.0.162.gfafddb0af9-goog Subject: [PATCH v1 2/5] perf help: Ensure clean_cmds is called on all paths From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Thomas Gleixner , Darren Hart , Davidlohr Bueso , "=?UTF-8?q?Andr=C3=A9=20Almeida?=" , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Avoid potential memory leaks. Signed-off-by: Ian Rogers --- tools/perf/util/help-unknown-cmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/perf/util/help-unknown-cmd.c b/tools/perf/util/help-unknown-cmd.c index ab9e16123626..eab99ea6ac01 100644 --- a/tools/perf/util/help-unknown-cmd.c +++ b/tools/perf/util/help-unknown-cmd.c @@ -92,6 +92,7 @@ const char *help_unknown_cmd(const char *cmd) main_cmds.names[0] = NULL; clean_cmdnames(&main_cmds); + clean_cmdnames(&other_cmds); fprintf(stderr, "WARNING: You called a perf program named '%s', " "which does not exist.\n" "Continuing under the assumption that you meant '%s'\n", @@ -114,5 +115,7 @@ const char *help_unknown_cmd(const char *cmd) fprintf(stderr, "\t%s\n", main_cmds.names[i]->name); } end: + clean_cmdnames(&main_cmds); + clean_cmdnames(&other_cmds); exit(1); } -- 2.41.0.162.gfafddb0af9-goog