From: Christian Brauner <brauner@kernel.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>,
Shaomin Deng <dengshaomin@cdjrlc.com>,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, Mao Zhu <zhumao001@208suo.com>
Subject: Re: [PATCH] fs: Fix comment typo
Date: Mon, 12 Jun 2023 10:34:55 +0200 [thread overview]
Message-ID: <20230612-daran-erhitzen-b839f13a6134@brauner> (raw)
In-Reply-To: <20230612-kabarett-vinylplatte-6e3843cd76a3@brauner>
On Mon, Jun 12, 2023 at 08:34:53AM +0200, Christian Brauner wrote:
> On Sun, Jun 11, 2023 at 01:50:34PM -0600, Jonathan Corbet wrote:
> > Bagas Sanjaya <bagasdotme@gmail.com> writes:
> >
> > > On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote:
> > >> From: Mao Zhu <zhumao001@208suo.com>
> > >>
> > >> Delete duplicated word in comment.
> > >
> > > On what function?
> >
> > Bagas, do I *really* have to ask you, yet again, to stop nitpicking our
> > contributors into the ground? It appears I do. So:
> >
> > Bagas, *stop* this. It's a typo patch removing an extraneous word. The
> > changelog is fine. We absolutely do not need you playing changelog cop
> > and harassing contributors over this kind of thing.
>
> 100% agreed.
>
> >
> > >> Signed-off-by: Mao Zhu <zhumao001@208suo.com>
> > >
> > > You're carrying someone else's patch, so besides SoB from original
> > > author, you need to also have your own SoB.
> >
> > This, instead, is a valid problem that needs to be fixed.
>
> Patch picked up and missing sender SOB added.
I've been informed that I may not be allowed to do that.
So dropping the sender SOB for now following willy's argument.
next prev parent reply other threads:[~2023-06-12 8:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-11 12:33 Shaomin Deng
2023-06-11 12:54 ` Bagas Sanjaya
2023-06-11 19:50 ` Jonathan Corbet
2023-06-11 20:07 ` Matthew Wilcox
2023-06-12 2:00 ` Bagas Sanjaya
2023-06-12 1:41 ` Bagas Sanjaya
2023-06-12 1:53 ` Bagas Sanjaya
2023-06-12 6:34 ` Christian Brauner
2023-06-12 8:34 ` Christian Brauner [this message]
2023-06-12 9:18 ` Bagas Sanjaya
2023-06-12 6:31 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230612-daran-erhitzen-b839f13a6134@brauner \
--to=brauner@kernel.org \
--cc=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=dengshaomin@cdjrlc.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=zhumao001@208suo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®