mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: beomsu kim <beomsu7.kim@samsung.com>
To: Chao Yu <chao@kernel.org>,
	"jaegeuk@kernel.org" <jaegeuk@kernel.org>,
	"linux-f2fs-devel@lists.sourceforge.net" 
	<linux-f2fs-devel@lists.sourceforge.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Yonggil Song <yonggil.song@samsung.com>,
	Seokhwan Kim <sukka.kim@samsung.com>,
	Daejun Park <daejun7.park@samsung.com>,
	Seonghun Kim <seonghun-sui.kim@samsung.com>
Subject: RE:(2) [PATCH] f2fs: including waf data in f2fs status information
Date: Mon, 12 Jun 2023 16:52:50 +0900	[thread overview]
Message-ID: <20230612075250epcms2p7d2e02243caa54d4a9ceb525a2b23d555@epcms2p7> (raw)
In-Reply-To: <f301845f-c358-4632-1df5-5944d7483072@kernel.org>

On 2023/6/2 12:48, beomsu kim wrote:
>> When evaluating in f2fs, it takes much time to obtain waf data.
>> This patch helps to obtain waf data without calcluation.
>> 
>> Signed-off-by: Beomsu Kim <beomsu7.kim@samsung.com>
>> ---
>>   fs/f2fs/iostat.c | 16 ++++++++++++++++
>>   1 file changed, 16 insertions(+)
>> 
>> diff --git a/fs/f2fs/iostat.c b/fs/f2fs/iostat.c
>> index 3d5bfb1ad585..6eab11b0610d 100644
>> --- a/fs/f2fs/iostat.c
>> +++ b/fs/f2fs/iostat.c
>> @@ -34,10 +34,22 @@ int __maybe_unused iostat_info_seq_show(struct seq_file *seq, void *offset)
>>   {
>>          struct super_block *sb = seq->private;
>>          struct f2fs_sb_info *sbi = F2FS_SB(sb);
>> +       int j;
>> +       unsigned long long waf = 0;
>> +       unsigned long long data_written_to_storage = 0;
>> +       unsigned long long data_written_by_user = 0;
>>   
>>          if (!sbi->iostat_enable)
>>                  return 0;
>>   
>> +       for (j = FS_DATA_IO; j <= FS_CP_META_IO; j++)
>
>FS_CDATA_IO is redundant?

I agree, and modified it.
		
>
>> +               data_written_to_storage += sbi->iostat_bytes[j];
>> +       for (j = FS_DATA_IO; j <= FS_CDATA_IO; j++)
>
>Just needs to include APP_WRITE_IO and APP_MAPPED_IO?

There is a slight time interval between requests in the form of APP_*_IO until they become requests in the form of FS_*_IO. On the other hand, we get the amount of file system meta data from FS_*_IO for 'data_written_to_storage'. So, If we use APP_*_IO for 'data_written_by_user', the 'waf' value returned during this time interval might have some difference from the actual value.

>
>Thanks,
>
>> +               data_written_by_user += sbi->iostat_bytes[j];
>> +
>> +       if (data_written_by_user > 0)
>> +               waf = data_written_to_storage * 100 / data_written_by_user;
>> +
>>          seq_printf(seq, "time:          %-16llu\n>", ktime_get_real_seconds());
>>          seq_printf(seq, "\t\t\t%-16s %-16s %-16s\n>",
>>                                  "io_bytes", "count", "avg_bytes");
>> @@ -81,6 +93,10 @@ int __maybe_unused iostat_info_seq_show(struct seq_file *seq, void *offset)
>>          IOSTAT_INFO_SHOW("fs discard", FS_DISCARD_IO);
>>          IOSTAT_INFO_SHOW("fs flush", FS_FLUSH_IO);
>>   
>> +       /* print waf */
>> +       seq_puts(seq, "[WAF]\n>");
>> +       seq_printf(seq, "fs waf:                %llu.%02llu\n>", waf / 100, waf % 100);
>> +
>>          return 0;
>>   }
>> 

      parent reply	other threads:[~2023-06-12  8:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230602044830epcms2p141ec782e866c2adc5a3142516f051b87@epcms2p1>
2023-06-02  4:48 ` beomsu kim
2023-06-02  8:52   ` Chao Yu
     [not found]   ` <CGME20230602044830epcms2p141ec782e866c2adc5a3142516f051b87@epcms2p7>
2023-06-12  7:52     ` beomsu kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230612075250epcms2p7d2e02243caa54d4a9ceb525a2b23d555@epcms2p7 \
    --to=beomsu7.kim@samsung.com \
    --cc=chao@kernel.org \
    --cc=daejun7.park@samsung.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=seonghun-sui.kim@samsung.com \
    --cc=sukka.kim@samsung.com \
    --cc=yonggil.song@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®