From: Leo Yan <leo.yan@linaro.org>
To: Shuai Xue <xueshuai@linux.alibaba.com>
Cc: alexander.shishkin@linux.intel.com, peterz@infradead.org,
mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com,
jolsa@kernel.org, namhyung@kernel.org, irogers@google.com,
adrian.hunter@intel.com, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
Baolin Wang <baolin.wang@linux.alibaba.com>
Subject: Re: [PATCH 1/2] perf/core: Bail out early if the request AUX area is out of bound
Date: Mon, 12 Jun 2023 18:05:02 +0800 [thread overview]
Message-ID: <20230612100502.GE217089@leoy-huanghe.lan> (raw)
In-Reply-To: <5fe7c14e-4dd4-3e7f-ece4-75da36c3b6c3@linux.alibaba.com>
On Mon, Jun 12, 2023 at 04:35:07PM +0800, Shuai Xue wrote:
[...]
> > Furthermore, I believe the AUX trace pages are only mapped for VMA
> > (continuous virtual address), the kernel will defer to map to physical
> > pages (which means it's not necessarily continuous physical pages)
> > when handling data abort caused by accessing the pages.
>
> I don't know why the rb->aux_pages is limit to allocated with continuous physical pages.
> so I just add a check to avoid oops and report a proper error code -EINVAL to
> user.
>
> I would like to use vmalloc() family to replace kmalloc() so that we could support
> allocate a more large AUX area if it is not necessarily continuous physical pages.
> Should we remove the restriction?
As you said, we are now able to support a maximum AUX trace buffer
size of up to 2GiB, and AUX trace buffer is per CPU wise.
Seems to me, 2GiB AUX buffer per CPU is big enough for most tracing
scenarios, right? Except you can provide profiling scenario which
must use bigger buffer size.
Another factor is the allocation of buffers from kmalloc() offers better
performance compared to allocation from vmalloc(), this is also
important for perf core layer.
Thanks,
Leo
next prev parent reply other threads:[~2023-06-12 10:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 5:24 [PATCH 0/2] Fix high-order allocations for AUX space Shuai Xue
2023-06-12 5:24 ` [PATCH 1/2] perf/core: Bail out early if the request AUX area is out of bound Shuai Xue
2023-06-12 7:38 ` Leo Yan
2023-06-12 8:35 ` Shuai Xue
2023-06-12 10:05 ` Leo Yan [this message]
2023-06-12 10:25 ` Leo Yan
2023-06-13 3:00 ` Shuai Xue
2023-06-12 8:47 ` James Clark
2023-06-12 5:24 ` [PATCH 2/2] perf/ring_buffer: Fix high-order allocations for AUX space with correct MAX_ORDER limit Shuai Xue
2023-06-12 8:30 ` Leo Yan
2023-06-12 8:35 ` Shuai Xue
2023-06-12 8:45 ` James Clark
2023-06-12 9:09 ` Leo Yan
2023-06-13 6:42 ` Shuai Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230612100502.GE217089@leoy-huanghe.lan \
--to=leo.yan@linaro.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=bpf@vger.kernel.org \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®