From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D85D4C7EE25 for ; Mon, 12 Jun 2023 11:37:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233682AbjFLLha (ORCPT ); Mon, 12 Jun 2023 07:37:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230039AbjFLLg7 (ORCPT ); Mon, 12 Jun 2023 07:36:59 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC0B11982 for ; Mon, 12 Jun 2023 04:16:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UNgxxIWKRNKpQwlHP1KcC4wpeFs5yQtKdY9XE7EOhUE=; b=r+hVUwUSdXB1J2bferuwIur7xv ReGSTN8VeVUxt3ghjhiXvnbBclv/A4Byh+KIAjwD20pcSLAnvy8VimybcOT815fKi62BzWQe7hxMV PSvwmmI0BqSpfktmk8sMwPUsO71vU/c1jeZcyXNVKxx+P07ERp+BtnbaPBSyTIzwe7b4b/BJ+7DOc 6TSQF8HYknfSGbx16MA1isKPXPeqJSzIo5Xstc9zlNFRpim7Bq3AXuKVdZOwxrodBZMALumlMj4aW 8PF5WV94/YVduMcsDFX57njjeUsU1btsOBp/qMSGmHdGlfhlupDYO9hyGXSJRWpXol0naooTohNcb arVJMdvQ==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1q8fWl-002Z8u-IK; Mon, 12 Jun 2023 11:16:03 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 6EDCA3002A9; Mon, 12 Jun 2023 13:16:02 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 5263024513501; Mon, 12 Jun 2023 13:16:02 +0200 (CEST) Date: Mon, 12 Jun 2023 13:16:02 +0200 From: Peter Zijlstra To: Tim Chen Cc: Juri Lelli , Vincent Guittot , Ricardo Neri , "Ravi V . Shankar" , Ben Segall , Daniel Bristot de Oliveira , Dietmar Eggemann , Len Brown , Mel Gorman , "Rafael J . Wysocki" , Srinivas Pandruvada , Steven Rostedt , Valentin Schneider , Ionela Voinescu , x86@kernel.org, linux-kernel@vger.kernel.org, Shrikanth Hegde , Srikar Dronamraju , naveen.n.rao@linux.vnet.ibm.com, Yicong Yang , Barry Song , Chen Yu , Hillf Danton Subject: Re: [Patch v2 1/6] sched/fair: Determine active load balance for SMT sched groups Message-ID: <20230612111602.GJ4253@hirez.programming.kicks-ass.net> References: <253f5272200d3cec3f24427262bb4e95244f681c.1686263351.git.tim.c.chen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <253f5272200d3cec3f24427262bb4e95244f681c.1686263351.git.tim.c.chen@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 08, 2023 at 03:32:27PM -0700, Tim Chen wrote: > @@ -10371,6 +10436,11 @@ static struct sched_group *find_busiest_group(struct lb_env *env) > */ > goto out_balanced; > > + if (busiest->group_type == group_smt_balance && > + smt_vs_nonsmt_groups(sds.local, sds.busiest)) > + /* Let non SMT CPU pull from SMT CPU sharing with sibling */ > + goto force_balance; > + > if (busiest->group_weight > 1 && > local->idle_cpus <= (busiest->idle_cpus + 1)) > /* Could you please add {} for all of them? The comment makes them all multi-line.