From: Kai Huang <kai.huang@intel.com>
To: linux-kernel@vger.kernel.org
Cc: kirill.shutemov@linux.intel.com, dave.hansen@linux.intel.com,
bp@alien8.de, tglx@linutronix.de, mingo@redhat.com,
peterz@infradead.org, hpa@zytor.com, x86@kernel.org,
jpoimboe@kernel.org, rostedt@goodmis.org, konrad.wilk@oracle.com,
Kai Huang <kai.huang@intel.com>
Subject: [PATCH v2] x86/kexec: Add a comment to relocate_kernel() for better readability
Date: Tue, 13 Jun 2023 00:34:38 +1200 [thread overview]
Message-ID: <20230612123438.469673-1-kai.huang@intel.com> (raw)
The reason to save %rcx to %r11 before calling swap_pages isn't that
obvious w/o looking into the swap_pages itself. Add a comment to
improve the readability.
Signed-off-by: Kai Huang <kai.huang@intel.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
---
v1 -> v2:
- Avoided line split in the comment.
- Added Kirill's Acked-by.
v1: https://lore.kernel.org/lkml/538335b164bf8b84b8a55c5654ed15d849479388.camel@intel.com/T/
---
arch/x86/kernel/relocate_kernel_64.S | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/kernel/relocate_kernel_64.S b/arch/x86/kernel/relocate_kernel_64.S
index 56cab1bb25f5..fea1aed16142 100644
--- a/arch/x86/kernel/relocate_kernel_64.S
+++ b/arch/x86/kernel/relocate_kernel_64.S
@@ -169,6 +169,7 @@ SYM_CODE_START_LOCAL_NOALIGN(identity_mapped)
wbinvd
1:
+ /* Save the preserve_context to %r11 as swap_pages clobbers %rcx */
movq %rcx, %r11
call swap_pages
base-commit: 409bf2895d71bb68bc5b8589036e5ed1ca30bada
--
2.40.1
reply other threads:[~2023-06-12 12:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230612123438.469673-1-kai.huang@intel.com \
--to=kai.huang@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®