From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C672AC7EE29 for ; Tue, 13 Jun 2023 07:40:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234798AbjFMHko (ORCPT ); Tue, 13 Jun 2023 03:40:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235289AbjFMHkh (ORCPT ); Tue, 13 Jun 2023 03:40:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68445AA for ; Tue, 13 Jun 2023 00:40:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F2C1861FC0 for ; Tue, 13 Jun 2023 07:40:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D35AEC433EF; Tue, 13 Jun 2023 07:40:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1686642035; bh=4y409Z4Eu1rh9icd4UWh1tWXkyxkDQTdIE6G/qeylyA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q5LvtlBIDtk6QZcyB/kcTnfiYSSyjgD0TdW7ZqyL3/X2kpaMncBMgA26hxyJ7kkVX vZvvbkJ6ldZzMD5k8paSNj/9KltZvqFFOcwfAidBOjc+nRvKsJ29fPswSUZq2zYxtz CQdwD4tqRmNXiZ1bok8IYUXiiIz1t936MZLrVrXU= Date: Tue, 13 Jun 2023 09:40:32 +0200 From: Greg KH To: Abhijit Gangurde Cc: nikhil.agarwal@amd.com, Nipun.Gupta@amd.com, geert@linux-m68k.org, linux-kernel@vger.kernel.org, git@amd.com, michal.simek@amd.com Subject: Re: [PATCH v4] cdx: Replace custom mcdi logging with print_hex_dump_debug() Message-ID: <2023061300-mouth-suffering-8c20@gregkh> References: <20230613065231.19932-1-abhijit.gangurde@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230613065231.19932-1-abhijit.gangurde@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 13, 2023 at 12:22:31PM +0530, Abhijit Gangurde wrote: > Replace custom mcdi logging for send and receive requests > with dynamic debug method print_hex_dump_debug(). > > Fixes: eb96b740192b ("cdx: add MCDI protocol interface for firmware interaction") This isn't a "fix", right? > Signed-off-by: Abhijit Gangurde > Closes: https://lore.kernel.org/lkml/CAMuHMdWTCdQagFFANygMgA8D0sWaoGxWv2AjibC3vwSd0UxuRw@mail.gmail.com/ This wasn't a "bug report" this was a "the code should be changed to not do this" type of thing. Part of normal development. Other than those nits, looks good, want to fix this up and resend a v5? thanks, greg k-h