From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Changbin Du <changbin.du@huawei.com>
Subject: [PATCH v2 0/2] Fix srcline addr2line issue with the ',' sentinel
Date: Mon, 12 Jun 2023 20:48:15 -0700 [thread overview]
Message-ID: <20230613034817.1356114-1-irogers@google.com> (raw)
addr2line makes it hard to detect when inline output has finished. To
detect it srcline issues a bogus ',' symbol and expects to see a
filename:line of "??:0". For binutils addr2line ',' gets turned into
address 0 and if there is a symbol there then the sentinel isn't
detected, this problem has been occurring with kernel binaries.
The issue was reported by and debugged by Changbin Du <changbin.du@huawei.com>.
v2. Incorporate feedback from Changbin.
Ian Rogers (2):
perf srcline: Make addr2line configuration failure more verbose
perf srcline: Make sentinel reading for binutils addr2line more robust
tools/perf/util/srcline.c | 93 ++++++++++++++++++++++++++++++---------
1 file changed, 73 insertions(+), 20 deletions(-)
--
2.41.0.162.gfafddb0af9-goog
next reply other threads:[~2023-06-13 3:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 3:48 Ian Rogers [this message]
2023-06-13 3:48 ` [PATCH v2 1/2] perf srcline: Make addr2line configuration failure more verbose Ian Rogers
2023-06-13 3:48 ` [PATCH v2 2/2] perf srcline: Make sentinel reading for binutils addr2line more robust Ian Rogers
2023-06-13 4:02 ` [PATCH v2 0/2] Fix srcline addr2line issue with the ',' sentinel Changbin Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230613034817.1356114-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=changbin.du@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®