From: Alasdair G Kergon <agk@redhat.com>
To: baomingtong001@208suo.com
Cc: agk <agk@redhat.com>, snitzer <snitzer@kernel.org>,
dm-devel <dm-devel@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dm: remove unneeded variable
Date: Wed, 14 Jun 2023 03:42:28 +0100 [thread overview]
Message-ID: <20230614024228.GA63706@agk-cloud1.hosts.prod.upshift.rdu2.redhat.com> (raw)
In-Reply-To: <202306141008237478337@208suo.com>
On Wed, Jun 14, 2023 at 10:10:33AM +0800, baomingtong001@208suo.com wrote:
> fix the following coccicheck warning:
> drivers/md/dm-snap-persistent.c:909:14-16: Unneeded variable: "sz".
> - unsigned int sz = 0;
> - return sz;
> + return 0;
Did the patched code compile OK for you?
The semantics of the DMEMIT macro are perhaps a tad unexpected.
Alasdair
next prev parent reply other threads:[~2023-06-14 2:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 2:10 baomingtong001
2023-06-14 2:42 ` Alasdair G Kergon [this message]
[not found] ` <a78b787e3c45de04df95c80dfc2aa511@208suo.com>
2023-06-14 18:48 ` Alasdair G Kergon
-- strict thread matches above, loose matches on Subject: below --
2021-11-11 7:53 cgel.zte
2021-11-11 16:50 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230614024228.GA63706@agk-cloud1.hosts.prod.upshift.rdu2.redhat.com \
--to=agk@redhat.com \
--cc=baomingtong001@208suo.com \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®