From: Andrew Morton <akpm@linux-foundation.org>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Minchan Kim <minchan@kernel.org>, Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Brian Geffon <bgeffon@google.com>
Subject: Re: [PATCH] zram: further limit recompression threshold
Date: Wed, 14 Jun 2023 12:52:10 -0700 [thread overview]
Message-ID: <20230614125210.3c6b5c1e34e18fbca7f59dae@linux-foundation.org> (raw)
In-Reply-To: <20230614141338.3480029-1-senozhatsky@chromium.org>
On Wed, 14 Jun 2023 23:13:12 +0900 Sergey Senozhatsky <senozhatsky@chromium.org> wrote:
> Recompression threshold should be below huge-size-class
> watermark.
The changelog explains what the code does, but not why it does it?
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -1753,7 +1753,7 @@ static ssize_t recompress_store(struct device *dev,
> }
> }
>
> - if (threshold >= PAGE_SIZE)
> + if (threshold >= huge_class_size)
> return -EINVAL;
>
> down_read(&zram->init_lock);
> --
> 2.41.0.162.gfafddb0af9-goog
next prev parent reply other threads:[~2023-06-14 19:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 14:13 Sergey Senozhatsky
2023-06-14 14:16 ` Brian Geffon
2023-06-14 19:52 ` Andrew Morton [this message]
2023-06-15 1:30 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230614125210.3c6b5c1e34e18fbca7f59dae@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bgeffon@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®