From: Perry Yuan <perry.yuan@amd.com>
To: <rafael.j.wysocki@intel.com>, <viresh.kumar@linaro.org>,
<Ray.Huang@amd.com>, <Mario.Limonciello@amd.com>
Cc: <Deepak.Sharma@amd.com>, <Wyes.Karny@amd.com>,
<gautham.shenoy@amd.com>, <Sunpeng.Li@amd.com>,
<Xinmei.Huang@amd.com>, <Xiaojian.Du@amd.com>, <Li.Meng@amd.com>,
<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v2 4/4] cpufreq: intel_pstate: Use the acpi_pm_profile_server() symbol
Date: Thu, 15 Jun 2023 02:33:33 -0400 [thread overview]
Message-ID: <20230615063333.4030395-1-perry.yuan@amd.com> (raw)
From: Mario Limonciello <mario.limonciello@amd.com>
Avoid duplication of functionality by using the generic symbol.
This does have a functional change that intel-pstate will now
match "SOHO server" as well.
Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
---
drivers/cpufreq/intel_pstate.c | 19 ++++---------------
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 2548ec92faa2..6401338971c7 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -313,18 +313,9 @@ static DEFINE_MUTEX(intel_pstate_limits_lock);
#ifdef CONFIG_ACPI
-static bool intel_pstate_acpi_pm_profile_server(void)
-{
- if (acpi_gbl_FADT.preferred_profile == PM_ENTERPRISE_SERVER ||
- acpi_gbl_FADT.preferred_profile == PM_PERFORMANCE_SERVER)
- return true;
-
- return false;
-}
-
static bool intel_pstate_get_ppc_enable_status(void)
{
- if (intel_pstate_acpi_pm_profile_server())
+ if (acpi_pm_profile_server())
return true;
return acpi_ppc;
@@ -481,10 +472,6 @@ static inline void intel_pstate_exit_perf_limits(struct cpufreq_policy *policy)
{
}
-static inline bool intel_pstate_acpi_pm_profile_server(void)
-{
- return false;
-}
#endif /* CONFIG_ACPI */
#ifndef CONFIG_ACPI_CPPC_LIB
@@ -2407,8 +2394,10 @@ static int intel_pstate_init_cpu(unsigned int cpunum)
if (hwp_active) {
intel_pstate_hwp_enable(cpu);
- if (intel_pstate_acpi_pm_profile_server())
+#ifdef CONFIG_ACPI
+ if (acpi_pm_profile_server())
hwp_boost = true;
+#endif
}
} else if (hwp_active) {
/*
--
2.34.1
next reply other threads:[~2023-06-15 6:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 6:33 Perry Yuan [this message]
2023-06-15 15:57 ` Rafael J. Wysocki
2023-06-19 2:53 ` Mario Limonciello
2023-06-20 9:23 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230615063333.4030395-1-perry.yuan@amd.com \
--to=perry.yuan@amd.com \
--cc=Deepak.Sharma@amd.com \
--cc=Li.Meng@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Ray.Huang@amd.com \
--cc=Sunpeng.Li@amd.com \
--cc=Wyes.Karny@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=Xinmei.Huang@amd.com \
--cc=gautham.shenoy@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®