From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A04E6EB64DC for ; Fri, 16 Jun 2023 10:28:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344436AbjFPK2C (ORCPT ); Fri, 16 Jun 2023 06:28:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344048AbjFPK10 (ORCPT ); Fri, 16 Jun 2023 06:27:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61D1C4483; Fri, 16 Jun 2023 03:26:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 36C8B63628; Fri, 16 Jun 2023 10:26:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E145C433C9; Fri, 16 Jun 2023 10:26:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686911169; bh=GS0pPVjWt188lZEoepBV2THYAmcEA8YdD0oC8UPiH2w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GnD/aEpDrTy5n1Xu2roLuevA3iSC1f0qvobXTi2kUP18as3m2bAWU1xDXS6dKSpPL 6GkW8Pa8CR0TeuOxh2ql0UpY2vANJvMRaOWqtMLe43LVbrYNkkZ8HGHoBWFSoj/j4n Akgo1EkB6E86fCPLMXcFp9lylnhA7PNXgc5/+owk9N4tlSM5sLJoMp7ssBUMTXvcLg j65SFvlTePwHUP5UV/CIHdi7sEbHSYbA8G6I6XJGcdhOI4RFFvVQL9ADLkxjwYnQSL oIjYjMyFrr6+9HeLePhwba2jIXxZhEvl0ipG0PEznjKiD2yb6Kytj9FP+wguQ6YJLK 3XnVxqT9nnVrw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nitesh Shetty , Anuj Gupta , Jens Axboe , Sasha Levin , bvanassche@acm.org, kch@nvidia.com, damien.lemoal@opensource.wdc.com, vincent.fu@samsung.com, error27@gmail.com, akinobu.mita@gmail.com, shinichiro.kawasaki@wdc.com, linux-block@vger.kernel.org Subject: [PATCH AUTOSEL 6.3 22/30] null_blk: Fix: memory release when memory_backed=1 Date: Fri, 16 Jun 2023 06:25:10 -0400 Message-Id: <20230616102521.673087-22-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230616102521.673087-1-sashal@kernel.org> References: <20230616102521.673087-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.3.8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nitesh Shetty [ Upstream commit 8cfb98196cceec35416041c6b91212d2b99392e4 ] Memory/pages are not freed, when unloading nullblk driver. Steps to reproduce issue 1.free -h total used free shared buff/cache available Mem: 7.8Gi 260Mi 7.1Gi 3.0Mi 395Mi 7.3Gi Swap: 0B 0B 0B 2.modprobe null_blk memory_backed=1 3.dd if=/dev/urandom of=/dev/nullb0 oflag=direct bs=1M count=1000 4.modprobe -r null_blk 5.free -h total used free shared buff/cache available Mem: 7.8Gi 1.2Gi 6.1Gi 3.0Mi 398Mi 6.3Gi Swap: 0B 0B 0B Signed-off-by: Anuj Gupta Signed-off-by: Nitesh Shetty Link: https://lore.kernel.org/r/20230605062354.24785-1-nj.shetty@samsung.com Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/block/null_blk/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c index 14491952047f5..3b6b4cb400f42 100644 --- a/drivers/block/null_blk/main.c +++ b/drivers/block/null_blk/main.c @@ -2212,6 +2212,7 @@ static void null_destroy_dev(struct nullb *nullb) struct nullb_device *dev = nullb->dev; null_del_dev(nullb); + null_free_device_storage(dev, false); null_free_dev(dev); } -- 2.39.2