From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36585EB64DB for ; Fri, 16 Jun 2023 10:29:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344651AbjFPK3d (ORCPT ); Fri, 16 Jun 2023 06:29:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344225AbjFPK2Y (ORCPT ); Fri, 16 Jun 2023 06:28:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A91346AE; Fri, 16 Jun 2023 03:26:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BF6CB62DD8; Fri, 16 Jun 2023 10:26:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA8F9C433CA; Fri, 16 Jun 2023 10:26:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686911171; bh=VRkjnQDfjXAu6adCt3PdtX8T/zECSCAXojz7WBO3BNU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vFx6SfUdgarjHm7N5h+A1ettRCZ3kHj3b2NLqsr9WUrM215UkuN9Zn6qwEBq4KkCy uHX92L1N8Jqy2ZPUnmMTCXUhKY5OxUK/V8LNfGdSwolWHO3rdwOJ9QMndoV1GiW9jI aUyxC7wQ7r/uND+Hmwa1JYKpPs1ySzRtZYzQSPcg5M24OcMwsfKMCiMk8SgICBW8wW isOc+P2OQ3K/hHE1Fj2+UxC6A6MpH7iNrMIJRNqDlXfKpNy60YAtR7PtIb7/tOULU2 aUNI0i6RH27lhw6Cbdb7MtfypboZoQKzsXQmQ/rHkq+VoDb5pgZfGsQuH/GqbnH3xK l3zRX8jx2Bd1A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Inki Dae , Andi Shyti , Sasha Levin , sw0312.kim@samsung.com, kyungmin.park@samsung.com, airlied@gmail.com, daniel@ffwll.ch, krzysztof.kozlowski@linaro.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH AUTOSEL 6.3 23/30] drm/exynos: vidi: fix a wrong error return Date: Fri, 16 Jun 2023 06:25:11 -0400 Message-Id: <20230616102521.673087-23-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230616102521.673087-1-sashal@kernel.org> References: <20230616102521.673087-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.3.8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Inki Dae [ Upstream commit 4a059559809fd1ddbf16f847c4d2237309c08edf ] Fix a wrong error return by dropping an error return. When vidi driver is remvoed, if ctx->raw_edid isn't same as fake_edid_info then only what we have to is to free ctx->raw_edid so that driver removing can work correctly - it's not an error case. Signed-off-by: Inki Dae Reviewed-by: Andi Shyti Signed-off-by: Sasha Levin --- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exynos/exynos_drm_vidi.c index 4d56c8c799c5a..f5e1adfcaa514 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c @@ -469,8 +469,6 @@ static int vidi_remove(struct platform_device *pdev) if (ctx->raw_edid != (struct edid *)fake_edid_info) { kfree(ctx->raw_edid); ctx->raw_edid = NULL; - - return -EINVAL; } component_del(&pdev->dev, &vidi_component_ops); -- 2.39.2