From: "min15.li" <min15.li@samsung.com>
To: axboe@kernel.dk, willy@infradead.org, hch@lst.de,
dlemoal@kernel.org, gregkh@linuxfoundation.org, wsa@kernel.org,
vkoul@kernel.org
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
"min15.li" <min15.li@samsung.com>
Subject: [PATCH v2] block: add capacity validation in bdev_add_partition()
Date: Fri, 16 Jun 2023 11:05:57 +0000 [thread overview]
Message-ID: <20230616110557.12106-1-min15.li@samsung.com> (raw)
In-Reply-To: <CGME20230616030739epcas5p31e705be33bf080f988702d42534ad32f@epcas5p3.samsung.com>
In the function bdev_add_partition(),there is no check that the start
and end sectors exceed the size of the disk before calling add_partition.
When we call the block's ioctl interface directly to add a partition,
and the capacity of the disk is set to 0 by driver,the command will
continue to execute.
v1->v2: check for overflows of the start + length value and put
the capacity check at the beginning of the function.
Signed-off-by: min15.li <min15.li@samsung.com>
---
block/partitions/core.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/block/partitions/core.c b/block/partitions/core.c
index 49e0496ff23c..3546b43d5124 100644
--- a/block/partitions/core.c
+++ b/block/partitions/core.c
@@ -438,8 +438,20 @@ int bdev_add_partition(struct gendisk *disk, int partno, sector_t start,
{
struct block_device *part;
int ret;
+ sector_t end;
+ sector_t capacity = get_capacity(disk);
mutex_lock(&disk->open_mutex);
+ if (check_add_overflow(start, length, &end)) {
+ ret = -EINVAL;
+ goto out;
+ }
+
+ if (start >= capacity || end > capacity) {
+ ret = -EINVAL;
+ goto out;
+ }
+
if (!disk_live(disk)) {
ret = -ENXIO;
goto out;
--
2.34.1
next parent reply other threads:[~2023-06-16 7:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230616030739epcas5p31e705be33bf080f988702d42534ad32f@epcas5p3.samsung.com>
2023-06-16 11:05 ` min15.li [this message]
2023-06-16 7:17 ` Christoph Hellwig
2023-06-16 8:03 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230616110557.12106-1-min15.li@samsung.com \
--to=min15.li@samsung.com \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=willy@infradead.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®