From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B691DEB64DA for ; Fri, 16 Jun 2023 13:13:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345394AbjFPNNE (ORCPT ); Fri, 16 Jun 2023 09:13:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345450AbjFPNNA (ORCPT ); Fri, 16 Jun 2023 09:13:00 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E87435A8 for ; Fri, 16 Jun 2023 06:12:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4mU8x520FLqn0SjM47TmoR73YNkYMrZiFQJZY5V0fU4=; b=FVA72heOUJ9o0vpn884c2kCKmw PeG3+gXouMk00gZ86Tfv+gfIy7JephfC+bEIBkAS5NsXGvelKqWv4ORcRNdmITS3Q8Z0zFzPkcIgN +//In3n6hTMt1gbNLvEtgf6wg+Jj2oizWlQOmjDRvaaUBTNv+619o3/k7jYYx4iQJLZ5DNiyvsw7n G9zkJ43I5vxSMSHru5PxzkXqkpTKqt14nGpTVJKgI/Nw6cJPNwW1dxJFP31xOWBEYt5Pnlgby2olx N4S+znAljTdIipaZR/C2WwA8K095UlSuYjjX7DqCzF3QF716YPIoPdf9nEL58JGoDqtjw9iueBm2U Oyj0nS8w==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qA9Fr-0091oc-Ss; Fri, 16 Jun 2023 13:12:43 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 65B7230020B; Fri, 16 Jun 2023 15:12:43 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 3A1F02743896D; Fri, 16 Jun 2023 15:12:43 +0200 (CEST) Date: Fri, 16 Jun 2023 15:12:43 +0200 From: Peter Zijlstra To: Daniel Bristot de Oliveira Cc: Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , linux-kernel@vger.kernel.org, Luca Abeni , Tommaso Cucinotta , Thomas Gleixner , Joel Fernandes , Vineeth Pillai , Shuah Khan Subject: Re: [RFC PATCH V3 5/6] sched/fair: Add trivial fair server Message-ID: <20230616131243.GO83892@hirez.programming.kicks-ass.net> References: <8db5a49ea92ad8b875d331d6136721645a382fe8.1686239016.git.bristot@kernel.org> <20230616125946.GN83892@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 16, 2023 at 03:00:57PM +0200, Daniel Bristot de Oliveira wrote: > On 6/16/23 14:59, Peter Zijlstra wrote: > > On Thu, Jun 08, 2023 at 05:58:17PM +0200, Daniel Bristot de Oliveira wrote: > >> +void fair_server_init(struct rq *rq) > >> +{ > >> + struct sched_dl_entity *dl_se = &rq->fair_server; > >> + > >> + init_dl_entity(dl_se); > >> + > >> + dl_se->dl_runtime = TICK_NSEC; > >> + dl_se->dl_deadline = 20 * TICK_NSEC; > >> + dl_se->dl_period = 20 * TICK_NSEC; > >> + > >> + dl_server_init(dl_se, rq, fair_server_has_tasks, fair_server_pick); > >> +} > > > > These here numbers should obviously become a tunable somewhere... :-) > > From sched_rt_runtime and sched_rt_period, no? Well, probably new names. IIRC those are also limits on the whole rt-cgroup mess, so e can't trivially change it without also ripping all that out, and that's a little bit more work. Ripping out the basic throttle is much simpler than replacing all that and should be done earlier.