From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: William Hubbs <w.d.hubbs@gmail.com>,
Chris Brannon <chris@the-brannons.com>,
Kirk Reiser <kirk@reisers.ca>,
kernel@collabora.com, kernel-janitors@vger.kernel.org,
speakup@linux-speakup.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] accessibility: speakup: remove linux/version.h
Date: Fri, 16 Jun 2023 16:50:28 +0200 [thread overview]
Message-ID: <20230616145028.7rzrbqfj7wmoenj6@begin> (raw)
In-Reply-To: <fb6121fc-101f-0779-b752-ac8202eb761e@collabora.com>
Muhammad Usama Anjum, le ven. 16 juin 2023 17:53:12 +0500, a ecrit:
> Soft reminder.
It somehow hadn't appeared in my inbox.
> On 3/3/23 5:51 PM, Muhammad Usama Anjum wrote:
> > make versioncheck reports the following:
> > ./drivers/accessibility/speakup/genmap.c: 13 linux/version.h not needed.
> > ./drivers/accessibility/speakup/makemapdata.c: 13 linux/version.h not needed.
> >
> > So remove linux/version.h from both of these files.
> >
> > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Thanks!
> > ---
> > drivers/accessibility/speakup/genmap.c | 1 -
> > drivers/accessibility/speakup/makemapdata.c | 1 -
> > 2 files changed, 2 deletions(-)
> >
> > diff --git a/drivers/accessibility/speakup/genmap.c b/drivers/accessibility/speakup/genmap.c
> > index 0125000e00d9..0882bab10fb8 100644
> > --- a/drivers/accessibility/speakup/genmap.c
> > +++ b/drivers/accessibility/speakup/genmap.c
> > @@ -10,7 +10,6 @@
> > #include <stdio.h>
> > #include <libgen.h>
> > #include <string.h>
> > -#include <linux/version.h>
> > #include <ctype.h>
> > #include "utils.h"
> >
> > diff --git a/drivers/accessibility/speakup/makemapdata.c b/drivers/accessibility/speakup/makemapdata.c
> > index d7d41bb9b05f..55e4ef8a93dc 100644
> > --- a/drivers/accessibility/speakup/makemapdata.c
> > +++ b/drivers/accessibility/speakup/makemapdata.c
> > @@ -10,7 +10,6 @@
> > #include <stdio.h>
> > #include <libgen.h>
> > #include <string.h>
> > -#include <linux/version.h>
> > #include <ctype.h>
> > #include "utils.h"
> >
>
> --
> BR,
> Muhammad Usama Anjum
>
--
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.
next prev parent reply other threads:[~2023-06-16 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 12:51 Muhammad Usama Anjum
2023-03-03 13:22 ` Samuel Thibault
2023-06-16 12:53 ` Muhammad Usama Anjum
2023-06-16 14:50 ` Samuel Thibault [this message]
2023-06-28 10:11 ` Muhammad Usama Anjum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230616145028.7rzrbqfj7wmoenj6@begin \
--to=samuel.thibault@ens-lyon.org \
--cc=chris@the-brannons.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=speakup@linux-speakup.org \
--cc=usama.anjum@collabora.com \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®