From: Sam Ravnborg <sam@ravnborg.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Ruihai Zhou <zhouruihai@huaqin.corp-partner.google.com>,
Stephen Boyd <swboyd@chromium.org>,
yangcong <yangcong5@huaqin.corp-partner.google.com>,
Jitao Shi <jitao.shi@mediatek.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/panel: boe-tv101wum-nl6: Drop macros and open code sequences
Date: Fri, 16 Jun 2023 18:42:43 +0200 [thread overview]
Message-ID: <20230616164243.GB1697490@ravnborg.org> (raw)
In-Reply-To: <20230615-fix-boe-tv101wum-nl6-v1-1-8ac378405fb7@linaro.org>
Hi Linus,
On Thu, Jun 15, 2023 at 10:21:37PM +0200, Linus Walleij wrote:
> The boe-tv101wum-nl6 is reinventing the mechanism to send command
> sequences that we usually nix during review, but I missed this one
> so fixing it up myself.
>
> Also use the explicit function calls to mipi_dsi_dcs_exit_sleep_mode()
> and mipi_dsi_dcs_set_display_on() instead of reimplementing them
> with homegrown sequences.
It looks like the same sequence of calls are used in all init functions,
maybe move them out to the caller.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
I have browsed the patch, but it was impossible for me to review in
details due to the massive changes.
But the final result looks good!
With the static added as the robot noticed:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
next prev parent reply other threads:[~2023-06-16 16:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 20:21 [PATCH 0/2] Fix up the boe-tv101wum-nl6 panel driver Linus Walleij
2023-06-15 20:21 ` [PATCH 1/2] drm/panel: boe-tv101wum-nl6: Drop macros and open code sequences Linus Walleij
2023-06-15 22:10 ` kernel test robot
2023-06-16 16:42 ` Sam Ravnborg [this message]
2023-06-15 20:21 ` [PATCH 2/2] drm/panel: boe-tv101wum-nl6: Drop surplus prepare tracking Linus Walleij
2023-06-16 16:44 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230616164243.GB1697490@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jitao.shi@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=swboyd@chromium.org \
--cc=yangcong5@huaqin.corp-partner.google.com \
--cc=zhouruihai@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®