From: Alan Huang <mmpgouride@gmail.com>
To: paulmck@kernel.org
Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
Alan Huang <mmpgouride@gmail.com>
Subject: [PATCH] rcu: Add necessary WRITE_ONCE()
Date: Mon, 19 Jun 2023 09:46:24 +0000 [thread overview]
Message-ID: <20230619094624.205990-1-mmpgouride@gmail.com> (raw)
Commit c54a2744497d("list: Add hlist_unhashed_lockless()") and
commit 860c8802ace1("rcu: Use WRITE_ONCE() for assignments to
->pprev for hlist_nulls") added various WRITE_ONCE() to pair with
the READ_ONCE() in hlist_unhashed_lockless(), but there are still
some places where WRITE_ONCE() was not added, this commit adds that.
Also add WRITE_ONCE() to pair with the READ_ONCE() in hlist_empty().
Signed-off-by: Alan Huang <mmpgouride@gmail.com>
---
include/linux/list.h | 6 +++---
include/linux/list_nulls.h | 2 +-
include/linux/rculist_nulls.h | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/linux/list.h b/include/linux/list.h
index ac366958ea..ef2d895d3c 100644
--- a/include/linux/list.h
+++ b/include/linux/list.h
@@ -912,7 +912,7 @@ static inline void hlist_del(struct hlist_node *n)
{
__hlist_del(n);
n->next = LIST_POISON1;
- n->pprev = LIST_POISON2;
+ WRITE_ONCE(n->pprev, LIST_POISON2);
}
/**
@@ -1026,8 +1026,8 @@ static inline void hlist_move_list(struct hlist_head *old,
{
new->first = old->first;
if (new->first)
- new->first->pprev = &new->first;
- old->first = NULL;
+ WRITE_ONCE(new->first->pprev, &new->first);
+ WRITE_ONCE(old->first, NULL);
}
#define hlist_entry(ptr, type, member) container_of(ptr,type,member)
diff --git a/include/linux/list_nulls.h b/include/linux/list_nulls.h
index fa6e8471bd..b63b0589fa 100644
--- a/include/linux/list_nulls.h
+++ b/include/linux/list_nulls.h
@@ -95,7 +95,7 @@ static inline void hlist_nulls_add_head(struct hlist_nulls_node *n,
n->next = first;
WRITE_ONCE(n->pprev, &h->first);
- h->first = n;
+ WRITE_ONCE(h->first, n);
if (!is_a_nulls(first))
WRITE_ONCE(first->pprev, &n->next);
}
diff --git a/include/linux/rculist_nulls.h b/include/linux/rculist_nulls.h
index ba4c00dd80..c65121655b 100644
--- a/include/linux/rculist_nulls.h
+++ b/include/linux/rculist_nulls.h
@@ -138,7 +138,7 @@ static inline void hlist_nulls_add_tail_rcu(struct hlist_nulls_node *n,
if (last) {
n->next = last->next;
- n->pprev = &last->next;
+ WRITE_ONCE(n->pprev, &last->next);
rcu_assign_pointer(hlist_nulls_next_rcu(last), n);
} else {
hlist_nulls_add_head_rcu(n, h);
--
2.34.1
reply other threads:[~2023-06-19 9:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230619094624.205990-1-mmpgouride@gmail.com \
--to=mmpgouride@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®