From: Baskaran Kannan <Baski.Kannan@amd.com>
To: <Mario.Limonciello@amd.com>, <babu.moger@amd.com>,
<baski.kannan@amd.com>, <clemens@ladisch.de>, <jdelvare@suse.com>,
<linux@roeck-us.net>, <linux-hwmon@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: Baskaran Kannan <Baski.Kannan@amd.com>
Subject: [PATCH v3] hwmon: (k10temp) Enable AMD3255 Proc to show negative temperature
Date: Mon, 19 Jun 2023 11:54:14 -0500 [thread overview]
Message-ID: <20230619165413.806450-1-Baski.Kannan@amd.com> (raw)
Industrial processor i3255 supports temperatures -40 deg celcius
to 105 deg Celcius. The current implementation of k10temp_read_temp
rounds off any negative
temperatures to '0'. To fix this, the following changes have been made.
Added a flag 'disp_negative' to struct k10temp_data to support
AMD i3255 processors. Flag 'disp_negative' is set if 3255 processor
is found during k10temp_probe. Flag 'disp_negative' is used to determine
whether to round off negative temperatures to '0' in k10temp_read_temp.
Signed-off-by: Baskaran Kannan <Baski.Kannan@amd.com>
---
drivers/hwmon/k10temp.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
index 7b177b9fbb09..2613420d43ff 100644
--- a/drivers/hwmon/k10temp.c
+++ b/drivers/hwmon/k10temp.c
@@ -86,6 +86,7 @@ struct k10temp_data {
u32 show_temp;
bool is_zen;
u32 ccd_offset;
+ bool disp_negative;
};
#define TCTL_BIT 0
@@ -204,12 +205,12 @@ static int k10temp_read_temp(struct device *dev, u32 attr, int channel,
switch (channel) {
case 0: /* Tctl */
*val = get_raw_temp(data);
- if (*val < 0)
+ if (*val < 0 && !data->disp_negative)
*val = 0;
break;
case 1: /* Tdie */
*val = get_raw_temp(data) - data->temp_offset;
- if (*val < 0)
+ if (*val < 0 && !data->disp_negative)
*val = 0;
break;
case 2 ... 13: /* Tccd{1-12} */
@@ -405,6 +406,9 @@ static int k10temp_probe(struct pci_dev *pdev, const struct pci_device_id *id)
data->pdev = pdev;
data->show_temp |= BIT(TCTL_BIT); /* Always show Tctl */
+ if (boot_cpu_data.x86 == 0x17 && boot_cpu_data.x86_model < 0x8)
+ data->disp_negative = true;
+
if (boot_cpu_data.x86 == 0x15 &&
((boot_cpu_data.x86_model & 0xf0) == 0x60 ||
(boot_cpu_data.x86_model & 0xf0) == 0x70)) {
--
2.25.1
next reply other threads:[~2023-06-19 16:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 16:54 Baskaran Kannan [this message]
2023-06-19 17:07 ` Guenter Roeck
2023-06-19 18:02 ` Limonciello, Mario
2023-06-19 18:40 ` Guenter Roeck
2023-06-19 18:53 ` Limonciello, Mario
2023-06-19 19:48 ` Guenter Roeck
[not found] ` <65eb7961-755a-a11b-906b-aae237216d5f@amd.com>
2023-06-19 20:40 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230619165413.806450-1-Baski.Kannan@amd.com \
--to=baski.kannan@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=babu.moger@amd.com \
--cc=clemens@ladisch.de \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®