From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB019EB64D7 for ; Tue, 20 Jun 2023 08:09:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231793AbjFTIJl (ORCPT ); Tue, 20 Jun 2023 04:09:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231776AbjFTIJe (ORCPT ); Tue, 20 Jun 2023 04:09:34 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4401D10D4 for ; Tue, 20 Jun 2023 01:09:31 -0700 (PDT) Received: from mail.alien8.de (mail.alien8.de [IPv6:2a01:4f9:3051:3f93::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 5E11F1EC03C0; Tue, 20 Jun 2023 10:09:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1687248569; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=2BsLbLBKCKD11yVfF9a6aqGZpwTBqw419MBlZgLt84o=; b=cXvDQGRhxymodi9LYew/kMSqZM+b7D4dBh+xdrqmocNHIrm0RhKk5DTlHUnz7s3bAhmk+9 ibOtecitvUyCC+ma/Fn8ZokBfU6QY2KG7CC8H3wIuxP+5PuIlbHov2OuBD6RWHCYvoyzgk FprlJbz7dVQsfGRgiOiwmDHnei9MSWQ= X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id UopwDzRJabpM; Tue, 20 Jun 2023 08:09:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1687248567; bh=2BsLbLBKCKD11yVfF9a6aqGZpwTBqw419MBlZgLt84o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KD9QTeD0SpuS9FnseMNmpOMndaztHqYhGixNYthjFCljVk9SpESy2TlvhDWZCiXQa IyJXIPQEudVGrGfj3Ai325HDkT//eSlyQEBPMMH4fVKFmK+uajctbmIrN0BTU1dpv7 0uEJTundN0k5rgAo6PJshpQkRicKdi72XmAIbsgCxlVOnc10zKLSb1k8xK95+Yk9oK ETMuZOFS41oyE9uj4lXViCFOYc8M5tKzyGGrb0GRWWdMkiei7Pnivq+j4PLF5TZqHg /G437GcdQtpJAKmK0yM1daJxw3aIiK/SCEwrOCbQhmqpl9gwiyXRpz3vRnrpFTbmKV 3q96klKloPFWuhuR+wX2oT8RGvnvIk+fC5w0D4iPl3UxmMvJu+Ugx2Pg3Kr5/n38r7 tRsqBXdh31ZqlTrdTtZ/0BB1N2wReM/Mp228+6Dg4c7Hc9tZEMmV8KTHHf2KylvR25 oRmyNylQtWhmncthw+XTVD2eNeBFvILtzypXwYRvBSK+nvbF/zu19lXYTII+ntTopn UoxwThmwzhCUb+Jef1OoZgQ4bR3JVdDwMEnmKTkAxuuHZDZebxzZuHqbaolDmdyqBf YjQvgKonOgv14UtM31ClPr4keZcdZpYbsaQcTpGZhFAwMGZRrs0oHWBY88eZGwY6Vg FWfXyFJSUgLkmg7Yk+LuLO0E= Received: from zn.tnic (p200300EA971dC5b2329C23FffEa6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971d:c5b2:329c:23ff:fea6:a903]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id E2DA640E0034; Tue, 20 Jun 2023 08:09:15 +0000 (UTC) Date: Tue, 20 Jun 2023 10:09:09 +0200 From: Borislav Petkov To: Thomas Gleixner Cc: Ashok Raj , LKML , x86@kernel.org, Mario Limonciello , Tom Lendacky , Tony Battersby , Ashok Raj , Tony Luck , Arjan van de Veen , Eric Biederman Subject: Re: [patch v3 1/7] x86/smp: Make stop_other_cpus() more robust Message-ID: <20230620080909.GSZJFepTsycfJeWtWf@fat_crate.local> References: <20230615190036.898273129@linutronix.de> <20230615193330.263684884@linutronix.de> <87mt0z7si2.ffs@tglx> <87h6r770bv.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87h6r770bv.ffs@tglx> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 16, 2023 at 08:01:56PM +0200, Thomas Gleixner wrote: > From: Thomas Gleixner > Subject: x86/smp: Make stop_other_cpus() more robust > Date: Wed, 26 Apr 2023 18:37:00 +0200 > > Tony reported intermittent lockups on poweroff. His analysis identified the > wbinvd() in stop_this_cpu() as the culprit. This was added to ensure that > on SME enabled machines a kexec() does not leave any stale data in the > caches when switching from encrypted to non-encrypted mode or vice versa. > > That wbindv() is conditional on the SME feature bit which is read directly wbinvd() Otherwise: Reviewed-by: Borislav Petkov (AMD) -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette