From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48F5DEB64D8 for ; Wed, 21 Jun 2023 07:42:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231487AbjFUHm2 (ORCPT ); Wed, 21 Jun 2023 03:42:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231455AbjFUHmJ (ORCPT ); Wed, 21 Jun 2023 03:42:09 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99C13E65 for ; Wed, 21 Jun 2023 00:42:08 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qBsTa-0004Rj-9Y; Wed, 21 Jun 2023 09:42:02 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1qBsTX-0003Jg-KN; Wed, 21 Jun 2023 09:41:59 +0200 Date: Wed, 21 Jun 2023 09:41:59 +0200 From: Sascha Hauer To: Conor Dooley Cc: Mark Rutland , devicetree@vger.kernel.org, Conor Dooley , Heiko Stuebner , Krzysztof Kozlowski , linux-pm@vger.kernel.org, Robin Murphy , linux-kernel@vger.kernel.org, Rob Herring , Sebastian Reichel , linux-rockchip@lists.infradead.org, Kyungmin Park , MyungJoo Ham , Michael Riesch , kernel@pengutronix.de, Vincent Legoll , Will Deacon , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 22/26] dt-bindings: devfreq: event: rockchip,dfi: Add rk3588 support Message-ID: <20230621074159.GN18491@pengutronix.de> References: <20230616062101.601837-1-s.hauer@pengutronix.de> <20230616062101.601837-23-s.hauer@pengutronix.de> <20230616-swimwear-prewar-f9dce761d2ec@spud> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230616-swimwear-prewar-f9dce761d2ec@spud> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 16, 2023 at 08:05:33PM +0100, Conor Dooley wrote: > On Fri, Jun 16, 2023 at 08:20:57AM +0200, Sascha Hauer wrote: > > This adds rockchip,rk3588-dfi to the list of compatibles. Unlike ealier > > SoCs the rk3588 has four interrupts (one for each channel) instead of > > only one, so increase the number of allowed interrupts to four. > > > > Link: https://lore.kernel.org/r/20230524083153.2046084-23-s.hauer@pengutronix.de > > It's unclear what the point of this link is. The link was added automatically by b4. I re-applied the series from the last one I sent just to be sure that I base my work for the new series on the one I sent last time. I didn't remember that b4 adds these links, I should have disabled that option. > My comment still stands about whether only the new compatible should be > permitted to have more than one interrupt. I don't recall a response to > that question on the last version. My personal take on this is that such additions make the bindings more readable by machines, but less by humans. That's why I don't have enough intrinsic motivation to make this change. Anyway, if you insist then I'll make it for the next round. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |