From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C81E5EB64D7 for ; Wed, 21 Jun 2023 16:45:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229514AbjFUQor (ORCPT ); Wed, 21 Jun 2023 12:44:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229837AbjFUQoZ (ORCPT ); Wed, 21 Jun 2023 12:44:25 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8CD0184 for ; Wed, 21 Jun 2023 09:44:17 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 67F9821F6A; Wed, 21 Jun 2023 16:44:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1687365856; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aAVGXNrkgl4/ky+79KLnILYyQneRzEuevXG7/+WuCwo=; b=kWNL4pgiVzOgehactdZ52x2L0RyflNzlOQXRZTEhVrTfvHbgmYfzxLbMGHD4a0FJEqcfxc XefsD2kov1iV+8DFTR28+xClWTAYqSPTAPlEkjLgeIDuash9OSVAEaj4f1SXBS0xlCzPGN mGPPQ1M7FoiNbSYQLDYI09Y5xA0UQos= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1687365856; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aAVGXNrkgl4/ky+79KLnILYyQneRzEuevXG7/+WuCwo=; b=9Y9EOS8HVqnfgF1vq24ROfGYHGX1bn1txG1uSTTguGInUVU3/Qfhy+A/zTNiV8cqPEjbFz F7Ar/eNV/HJf8KBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5C0E0133E6; Wed, 21 Jun 2023 16:44:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wbpwFuAok2SPRwAAMHmgww (envelope-from ); Wed, 21 Jun 2023 16:44:16 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 05A76A075D; Wed, 21 Jun 2023 18:44:16 +0200 (CEST) Date: Wed, 21 Jun 2023 18:44:15 +0200 From: Jan Kara To: Jeff Layton Cc: Christian Brauner , Luis de Bethencourt , Salah Triki , Al Viro , Jan Kara , linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/79] befs: switch to new ctime accessors Message-ID: <20230621164415.7lcr3jrp2ndark4d@quack3> References: <20230621144507.55591-1-jlayton@kernel.org> <20230621144735.55953-1-jlayton@kernel.org> <20230621144735.55953-13-jlayton@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230621144735.55953-13-jlayton@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 21-06-23 10:45:27, Jeff Layton wrote: > In later patches, we're going to change how the ctime.tv_nsec field is > utilized. Switch to using accessor functions instead of raw accesses of > inode->i_ctime. > > Signed-off-by: Jeff Layton Looks good to me. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/befs/linuxvfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c > index eee9237386e2..1eee7baa808b 100644 > --- a/fs/befs/linuxvfs.c > +++ b/fs/befs/linuxvfs.c > @@ -363,7 +363,7 @@ static struct inode *befs_iget(struct super_block *sb, unsigned long ino) > inode->i_mtime.tv_sec = > fs64_to_cpu(sb, raw_inode->last_modified_time) >> 16; > inode->i_mtime.tv_nsec = 0; /* lower 16 bits are not a time */ > - inode->i_ctime = inode->i_mtime; > + inode_ctime_set(inode, inode->i_mtime); > inode->i_atime = inode->i_mtime; > > befs_ino->i_inode_num = fsrun_to_cpu(sb, raw_inode->inode_num); > -- > 2.41.0 > -- Jan Kara SUSE Labs, CR