From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E8ADEB64DD for ; Wed, 21 Jun 2023 17:58:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231538AbjFUR60 (ORCPT ); Wed, 21 Jun 2023 13:58:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230412AbjFUR6Q (ORCPT ); Wed, 21 Jun 2023 13:58:16 -0400 Received: from mail-0301.mail-europe.com (mail-0301.mail-europe.com [188.165.51.139]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1A321FF7; Wed, 21 Jun 2023 10:57:50 -0700 (PDT) Date: Wed, 21 Jun 2023 17:56:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1687370215; x=1687629415; bh=wHGz+4iR1yJG9gev8O3hnv7/wXS8nRLc1LqeNaYELLY=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=tbrO/bcpzOfBc7Yum/nWOy0bJ3CmwnIO7AXP3tq+xAjz8fFi6Zdacii4PSrKoPDbH g6qp5uw/I2cGFfEeyA8nqL1OuqHV+VRu0cvWICUOTxMjg4kA5kfKs4g2Odbok3mUkD hMLJmRQa7ogY8baGnbtM9MlFkKAr0ut0AyPu4OTryVBnSzNb2RsOPvFIIBxIYT7m/v UsEnV94qxpAGCGI8kuush9cInjpI+VPQHS+NjrELpAfzQ/ukJkNqSMktq/9UKxilh9 6M7ASrf9sBb1AcSAD3GnV6c9roS1sQG4k1yjzEVVenf5KYD78f225lQL94RYdL9x7E DvC+lKLv7X7JQ== To: krzysztof.kozlowski@linaro.org From: Raymond Hackley Cc: devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, lee@kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, luca@z3ntu.xyz, pavel@ucw.cz, raymondhackley@protonmail.com, robh+dt@kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [RESEND PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible Message-ID: <20230621175626.1229-1-raymondhackley@protonmail.com> In-Reply-To: <5cb59a5e-0ce5-7215-a14a-2ca2c1505b53@linaro.org> References: <20230602133533.260502-1-raymondhackley@protonmail.com> <20230602133714.260556-1-raymondhackley@protonmail.com> <5cb59a5e-0ce5-7215-a14a-2ca2c1505b53@linaro.org> Feedback-ID: 49437091:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Sunday, June 4th, 2023 at 10:43 AM, Krzysztof Kozlowski wrote: > On 02/06/2023 15:38, Raymond Hackley wrote: >=20 > > Add devicetree binding for Richtek RT5033 Flash LED charge pump used fo= r > > camera flash LEDs. >=20 >=20 > What are the similarities? Same register interface? Same pins? It's not > obvious and your commit should clear explain this. It will be also > justification why you did not make devices compatible. >=20 There is a similar way to control with 2 GPIO pins, strobe and enable, which is not described well in this patch set. Regards, Raymond