From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3902CEB64DB for ; Thu, 22 Jun 2023 06:31:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229915AbjFVGbz (ORCPT ); Thu, 22 Jun 2023 02:31:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjFVGbv (ORCPT ); Thu, 22 Jun 2023 02:31:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75BB5FC for ; Wed, 21 Jun 2023 23:31:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0A63261772 for ; Thu, 22 Jun 2023 06:31:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D074C433C8; Thu, 22 Jun 2023 06:31:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687415509; bh=8I3kJ3yOV1l9VHYXSTomQCnY9vroIhrMd3w0kNO1mok=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c4admOdfTJlntgfqiYhEbR+hYmU1RQkqVn3vkCG8qxpgca6Vu3XNiT2wZaSMSJ8jc im7uujX9ssnfnP/0KagDOeLDuQmYKE/fcaVBCzVifC21TMCT4mdjp1CPA7oAwlscn9 0pmlZ8AZtu9DNJfaKHdyesgXuhkLkL6Ck4NVzYs+o5KfZVkp+RnJzr2OJYvAF9zrZ6 dlFkIdUEtlsuE1BfNHC9GavOTCKpnGTJxzhmS20EsBGyI1TyArcdPLTOwdJz373DV3 6TwWzxM2DEP6aXcBJUb7t/SWbAhWAhuA3MaZ33f6497ZobQKof4mmspk7ODUkw0vyd JOA5z/W9a5kbw== Date: Wed, 21 Jun 2023 23:31:47 -0700 From: Josh Poimboeuf To: Christophe Leroy Cc: Peter Zijlstra , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] objtool: Make 'sec-address' always on Message-ID: <20230622063147.wpd4nxvludjjk2qa@treble> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 21, 2023 at 05:20:31PM +0200, Christophe Leroy wrote: > Most of the time objtool warnings are useless without the > absolute address within the section. > > Today there is --sec-address option to get it printed, but > that option is nowhere used and requires a change in Makefile > to use it. > > Having the address inside the section at all time in addition > to the address within the object doesn't hurt and will help. > > Remove the --sec-address option and print it at all time. This option actually feels like clutter to me. The func+offset format works fine, combined with scripts like objdump-func and faddr2line. And we also have a new OBJTOOL_VERBOSE=1 option which auto-disassembles the affected function. On x86 we've been using func+offset for console stack traces for many years, due to KASLR. So maybe we're just more used to it. But the scripts make it fine. Also it helps with identifying the same warning across different configs/compilers. -- Josh