From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Yang Jihong <yangjihong1@huawei.com>,
Carsten Haitzler <carsten.haitzler@arm.com>,
Changbin Du <changbin.du@huawei.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Jason Wang <wangborong@cdjrlc.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 1/3] perf dso: Sort symbols under lock
Date: Thu, 22 Jun 2023 22:45:18 -0700 [thread overview]
Message-ID: <20230623054520.4118442-2-irogers@google.com> (raw)
In-Reply-To: <20230623054520.4118442-1-irogers@google.com>
Determine if symbols are sorted, set the sorted flag and sort under
the dso lock. Done in the interest of thread safety.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/map.c | 3 +--
tools/perf/util/symbol.c | 8 ++++++--
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
index f30d34903aa4..a45708289cc6 100644
--- a/tools/perf/util/map.c
+++ b/tools/perf/util/map.c
@@ -398,8 +398,7 @@ struct symbol *map__find_symbol_by_name(struct map *map, const char *name)
return NULL;
dso = map__dso(map);
- if (!dso__sorted_by_name(dso))
- dso__sort_by_name(dso);
+ dso__sort_by_name(dso);
return dso__find_symbol_by_name(dso, name);
}
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index d275d3bef7d5..bb02047e1c59 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -613,8 +613,12 @@ struct symbol *dso__find_symbol_by_name(struct dso *dso, const char *name)
void dso__sort_by_name(struct dso *dso)
{
- dso__set_sorted_by_name(dso);
- return symbols__sort_by_name(&dso->symbol_names, &dso->symbols);
+ mutex_lock(&dso->lock);
+ if (!dso__sorted_by_name(dso)) {
+ symbols__sort_by_name(&dso->symbol_names, &dso->symbols);
+ dso__set_sorted_by_name(dso);
+ }
+ mutex_unlock(&dso->lock);
}
/*
--
2.41.0.162.gfafddb0af9-goog
next prev parent reply other threads:[~2023-06-23 5:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 5:45 [PATCH v3 0/3] Remove symbol_name_rb_node Ian Rogers
2023-06-23 5:45 ` Ian Rogers [this message]
2023-06-23 5:45 ` [PATCH v3 2/3] perf symbol: " Ian Rogers
2023-06-23 5:45 ` [PATCH v3 3/3] perf symbol_conf: Remove now unused sort_by_name Ian Rogers
2023-06-24 4:42 ` [PATCH v3 0/3] Remove symbol_name_rb_node Namhyung Kim
2023-06-24 23:37 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230623054520.4118442-2-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=carsten.haitzler@arm.com \
--cc=changbin.du@huawei.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wangborong@cdjrlc.com \
--cc=yangjihong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®