From: carlos.fernandez@technica-engineering.de
To: carlos.fernandez@technica-engineering.de, sd@queasysnail.net,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] net: macsec SCI assignment for ES = 0
Date: Fri, 23 Jun 2023 12:13:55 +0200 [thread overview]
Message-ID: <20230623101355.26790-1-carlos.fernandez@technica-engineering.de> (raw)
In-Reply-To: <ZJSnDZL-0hLxbDje@hog>
Regarding ES, it is only set if the first 6 octets of the SCI are equal to the MAC,
in which case SC=0 as well (IEEE802.1AE 9.5 TAG Control information).
However, if ES=0, it is incorrect to use source MAC as SCI (current implementation)
Regarding SC, as said in IEEE 802.1AE 9.9:
"An explicitly encoded SCI field in the SecTAG is not required on point-to-point links,
which are identified by (...), if the transmitting SecY uses only one transmit SC.
In that case, the secure association created by the SecY for the peer SecYs, together with
the direction of transmission of the secured MPDU, can be used to identify the transmitting SecY."
Therefore the case SC=0 is reserved for cases where both conditions apply: point-to-point links,
and only one transmit SC. This requirement makes the size of the reception lookup 1.
In conclusion, if we're in a NON end station MPDU scenario (ES = 0) and SCI it's not in the SegTAG (SC = 0),
we need to find the correct SCI. This can be done by searching it at the current (only) active RX_SC.
Thanks
--
Carlos
next prev parent reply other threads:[~2023-06-23 10:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 9:13 carlos.fernandez
2023-06-22 0:34 ` Jakub Kicinski
2023-06-22 8:00 ` Carlos Fernandez
2023-06-22 11:49 ` Carlos Fernandez
2023-06-22 19:54 ` Sabrina Dubroca
2023-06-23 10:13 ` carlos.fernandez [this message]
2023-06-23 15:40 ` Sabrina Dubroca
2023-06-27 6:13 ` carlos.fernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230623101355.26790-1-carlos.fernandez@technica-engineering.de \
--to=carlos.fernandez@technica-engineering.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®