From: Abel Vesa <abel.vesa@linaro.org>
To: Manivannan Sadhasivam <mani@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Bart Van Assche <bvanassche@acm.org>
Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
devicetree@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/5] scsi: dt-bindings: ufs: qcom: Fix ICE phandle
Date: Fri, 23 Jun 2023 14:30:05 +0300 [thread overview]
Message-ID: <20230623113009.2512206-2-abel.vesa@linaro.org> (raw)
In-Reply-To: <20230623113009.2512206-1-abel.vesa@linaro.org>
The check for 'qcom,ice' property is wrong. Fix it by checking using
if-required clause and expand the clocks minItems and maxItems for
platforms where 'qcom,ice' is not required so that it includes platforms
with single reg entry and clocks that do not provide an ICE one.
Fixes: 29a6d1215b7c ("scsi: ufs: dt-bindings: qcom: Add ICE phandle")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
index 943dafb69529..bdfa86a0cc98 100644
--- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
@@ -194,9 +194,8 @@ allOf:
# TODO: define clock bindings for qcom,msm8994-ufshc
- if:
- properties:
- qcom,ice:
- maxItems: 1
+ required:
+ - qcom,ice
then:
properties:
reg:
@@ -207,10 +206,10 @@ allOf:
else:
properties:
reg:
- minItems: 2
+ minItems: 1
maxItems: 2
clocks:
- minItems: 9
+ minItems: 8
maxItems: 11
unevaluatedProperties: false
--
2.34.1
next prev parent reply other threads:[~2023-06-23 11:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 11:30 [PATCH 0/5] scsi: dt-bindings: ufs: qcom: Some fixes to clear all dtbs_check warnings Abel Vesa
2023-06-23 11:30 ` Abel Vesa [this message]
2023-06-23 16:45 ` [PATCH 1/5] scsi: dt-bindings: ufs: qcom: Fix ICE phandle Krzysztof Kozlowski
2023-06-23 11:30 ` [PATCH 2/5] scsi: dt-bindings: ufs: qcom: Add compatible for sm6115 and sm6125 Abel Vesa
2023-06-23 12:33 ` Krzysztof Kozlowski
2023-06-23 12:34 ` Krzysztof Kozlowski
2023-06-23 11:30 ` [PATCH 3/5] scsi: dt-bindings: ufs: qcom: Add compatible for sc8180x Abel Vesa
2023-06-23 12:30 ` Krzysztof Kozlowski
2023-06-23 11:30 ` [PATCH 4/5] scsi: dt-bindings: ufs: qcom: Fix sm8450 clocks Abel Vesa
2023-06-23 12:21 ` Rob Herring
2023-06-23 20:12 ` Rob Herring
2023-06-23 11:30 ` [PATCH 5/5] scsi: dt-bindings: ufs: qcom: Fix warning for sdm845 by adding reg-names Abel Vesa
2023-06-23 12:31 ` Krzysztof Kozlowski
2023-06-23 12:38 ` Luca Weiss
2023-06-23 21:17 ` Rob Herring
2023-06-24 7:49 ` Krzysztof Kozlowski
2023-06-27 15:14 ` Rob Herring
2023-06-26 6:38 ` Luca Weiss
2023-06-26 7:41 ` Krzysztof Kozlowski
2023-06-26 8:19 ` Luca Weiss
2023-06-27 15:18 ` Rob Herring
2023-06-28 6:49 ` Luca Weiss
2023-06-24 12:30 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230623113009.2512206-2-abel.vesa@linaro.org \
--to=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®