From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED81FEB64DD for ; Fri, 23 Jun 2023 15:41:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232640AbjFWPlY (ORCPT ); Fri, 23 Jun 2023 11:41:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232258AbjFWPlR (ORCPT ); Fri, 23 Jun 2023 11:41:17 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8F4B2120; Fri, 23 Jun 2023 08:41:15 -0700 (PDT) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4A8EF838; Fri, 23 Jun 2023 17:40:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1687534837; bh=ArqSpTQIPLlQGIEbrbSLaivyf0ENs3vlfTMm4U/5SAs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wPzsCj056QJcxMA2HRsKQPOmZF6EdhSqvtkgvaVOL7ZfFp7bzuzwZ5MKa0lCU1jft AXPw1OlUdeV6dOWa6nUXpNxVrtRul9BxYzLC1/jDdi9Xl/f+W1+2Fespvd0Q8WwvnD 6dWN0vv27FDdYa8xb/VziVjWS5YWO/OoT/wCHW6A= Date: Fri, 23 Jun 2023 18:41:12 +0300 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Kieran Bingham , David Airlie , Daniel Vetter , Thomas Zimmermann , Magnus Damm , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 15/39] drm: renesas: shmobile: Improve error handling Message-ID: <20230623154112.GS2112@pendragon.ideasonboard.com> References: <100c650ab37ae09a142a93afa3734400a6a96757.1687423204.git.geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <100c650ab37ae09a142a93afa3734400a6a96757.1687423204.git.geert+renesas@glider.be> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, Thank you for the patch. On Thu, Jun 22, 2023 at 11:21:27AM +0200, Geert Uytterhoeven wrote: > Prepare for DT conversion, where panel probe can be deferred, by > streamlining error propagation and handling: > - Use dev_err_probe() to avoid printing error messages in case of > probe deferral, > - Propagate errors where needed. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c | 3 ++- > drivers/gpu/drm/renesas/shmobile/shmob_drm_kms.c | 14 +++++++++++--- > 2 files changed, 13 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c > index 9aa9800899976a23..50fca18282c5cb5e 100644 > --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c > +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c > @@ -228,7 +228,8 @@ static int shmob_drm_probe(struct platform_device *pdev) > > ret = shmob_drm_modeset_init(sdev); > if (ret < 0) { > - dev_err(&pdev->dev, "failed to initialize mode setting\n"); > + dev_err_probe(&pdev->dev, ret, > + "failed to initialize mode setting\n"); > goto err_free_drm_dev; > } > > diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_kms.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_kms.c > index 3051318ddc7999bc..1a62e7f8a8a9e6df 100644 > --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_kms.c > +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_kms.c > @@ -157,9 +157,17 @@ int shmob_drm_modeset_init(struct shmob_drm_device *sdev) > if (ret) > return ret; > > - shmob_drm_crtc_create(sdev); > - shmob_drm_encoder_create(sdev); > - shmob_drm_connector_create(sdev, &sdev->encoder); > + ret = shmob_drm_crtc_create(sdev); > + if (ret < 0) > + return ret; > + > + ret = shmob_drm_encoder_create(sdev); > + if (ret < 0) > + return ret; > + > + ret = shmob_drm_connector_create(sdev, &sdev->encoder); > + if (ret < 0) > + return ret; > > drm_kms_helper_poll_init(sdev->ddev); > -- Regards, Laurent Pinchart