From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3902EEB64D7 for ; Fri, 23 Jun 2023 17:13:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232022AbjFWRM6 (ORCPT ); Fri, 23 Jun 2023 13:12:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229734AbjFWRMr (ORCPT ); Fri, 23 Jun 2023 13:12:47 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D1D61BFA; Fri, 23 Jun 2023 10:12:46 -0700 (PDT) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B136E838; Fri, 23 Jun 2023 19:12:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1687540327; bh=Q2Cw1ygD0gWexI2pL2Jb6NsRmnG74wmibJoVnNEtGqA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RcwFBWaG+x5aska6fzT3PEjfRqJK8px1iFW4jcdr3q/9DrRZ6G5DdXBMmYrCGdjd6 r3aavajnfTodKNNqpqQix2RkKMx5kLp1nO2VCWr1LqKjmuUkha3Dps11i8Caykieff Wb5FVvEamAlYwsqVLvsOdXqlyUhuQToJxJqkxnmY= Date: Fri, 23 Jun 2023 20:12:43 +0300 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Kieran Bingham , David Airlie , Daniel Vetter , Thomas Zimmermann , Magnus Damm , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 33/39] drm: renesas: shmobile: Cleanup encoder Message-ID: <20230623171243.GK2112@pendragon.ideasonboard.com> References: <736a0b26a9393f82769b185e2daa30eb128ff240.1687423204.git.geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <736a0b26a9393f82769b185e2daa30eb128ff240.1687423204.git.geert+renesas@glider.be> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, Thank you for the patch. On Thu, Jun 22, 2023 at 11:21:45AM +0200, Geert Uytterhoeven wrote: > Most unused callbacks can be NULL pointers these days. > Drop a bunch of empty encoder callbacks. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart > --- > .../gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 26 ------------------- > 1 file changed, 26 deletions(-) > > diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c > index b184019d8b1ed89c..ef327da39bca415a 100644 > --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c > +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c > @@ -586,11 +586,6 @@ int shmob_drm_crtc_create(struct shmob_drm_device *sdev) > * Encoder > */ > > -static void shmob_drm_encoder_dpms(struct drm_encoder *encoder, int mode) > -{ > - /* No-op, everything is handled in the CRTC code. */ > -} > - > static bool shmob_drm_encoder_mode_fixup(struct drm_encoder *encoder, > const struct drm_display_mode *mode, > struct drm_display_mode *adjusted_mode) > @@ -613,29 +608,8 @@ static bool shmob_drm_encoder_mode_fixup(struct drm_encoder *encoder, > return true; > } > > -static void shmob_drm_encoder_mode_prepare(struct drm_encoder *encoder) > -{ > - /* No-op, everything is handled in the CRTC code. */ > -} > - > -static void shmob_drm_encoder_mode_set(struct drm_encoder *encoder, > - struct drm_display_mode *mode, > - struct drm_display_mode *adjusted_mode) > -{ > - /* No-op, everything is handled in the CRTC code. */ > -} > - > -static void shmob_drm_encoder_mode_commit(struct drm_encoder *encoder) > -{ > - /* No-op, everything is handled in the CRTC code. */ > -} > - > static const struct drm_encoder_helper_funcs encoder_helper_funcs = { > - .dpms = shmob_drm_encoder_dpms, > .mode_fixup = shmob_drm_encoder_mode_fixup, > - .prepare = shmob_drm_encoder_mode_prepare, > - .commit = shmob_drm_encoder_mode_commit, > - .mode_set = shmob_drm_encoder_mode_set, > }; > > int shmob_drm_encoder_create(struct shmob_drm_device *sdev) -- Regards, Laurent Pinchart