From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAC2CEB64DD for ; Fri, 23 Jun 2023 17:18:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232388AbjFWRSR (ORCPT ); Fri, 23 Jun 2023 13:18:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232327AbjFWRSN (ORCPT ); Fri, 23 Jun 2023 13:18:13 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 542C72703; Fri, 23 Jun 2023 10:18:11 -0700 (PDT) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 97FB3838; Fri, 23 Jun 2023 19:17:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1687540652; bh=0YZ1lxPbJiyDK0Mx7CR1+kV4GfIdauMzmbmUCh2M2yg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I80U+ueO1+v3u+Akn9EWaSLkx1e6Z1BF8fHrMrFnz3SNglr77oZHGHNOAV2/B6DaG tXC7IHbwESkqu7MTeeYE2l+kqt4cTfaZGH2A9W9m924sfNsORuMF64ebfvEtEbzaBU g6eaEz66f6uhobK56I8/6d5c9ZEmlggEQXKZe1Ig= Date: Fri, 23 Jun 2023 20:18:08 +0300 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Kieran Bingham , David Airlie , Daniel Vetter , Thomas Zimmermann , Magnus Damm , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 38/39] drm: renesas: shmobile: Atomic conversion part 3 Message-ID: <20230623171808.GN2112@pendragon.ideasonboard.com> References: <9fcb81f939a6c4f09204f084519bf29d993b005a.1687423204.git.geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9fcb81f939a6c4f09204f084519bf29d993b005a.1687423204.git.geert+renesas@glider.be> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, Thank you for the patch. On Thu, Jun 22, 2023 at 11:21:50AM +0200, Geert Uytterhoeven wrote: > Complete the conversion to atomic mode setting by converting the > connector, and setting the DRIVER_ATOMIC flag. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 5 +---- > drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c | 2 +- > 2 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c > index f2332bb0fbbd51a1..17456dde57637ab8 100644 > --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c > +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c > @@ -574,7 +574,6 @@ static void shmob_drm_connector_destroy(struct drm_connector *connector) > } > > static const struct drm_connector_funcs connector_funcs = { > - .dpms = drm_helper_connector_dpms, > .reset = drm_atomic_helper_connector_reset, > .fill_modes = drm_helper_probe_single_connector_modes, > .destroy = shmob_drm_connector_destroy, > @@ -644,9 +643,7 @@ int shmob_drm_connector_create(struct shmob_drm_device *sdev, > if (ret < 0) > goto error; > > - drm_helper_connector_dpms(connector, DRM_MODE_DPMS_OFF); > - drm_object_property_set_value(&connector->base, > - sdev->ddev.mode_config.dpms_property, DRM_MODE_DPMS_OFF); > + connector->dpms = DRM_MODE_DPMS_OFF; > > sdev->connector = connector; > > diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c > index c43f408d6b1fcc5b..576869164479ec6b 100644 > --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c > +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c > @@ -98,7 +98,7 @@ static irqreturn_t shmob_drm_irq(int irq, void *arg) > DEFINE_DRM_GEM_DMA_FOPS(shmob_drm_fops); > > static const struct drm_driver shmob_drm_driver = { > - .driver_features = DRIVER_GEM | DRIVER_MODESET, > + .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, > DRM_GEM_DMA_DRIVER_OPS, > .fops = &shmob_drm_fops, > .name = "shmob-drm", -- Regards, Laurent Pinchart