From: Steven Rostedt <rostedt@goodmis.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Beau Belgrave <beaub@linux.microsoft.com>,
Andrew Morton <akpm@linux-foundation.org>,
sunliming <sunliming@kylinos.cn>
Subject: Re: [GIT PULL] tracing: user_event fix for 6.4
Date: Sat, 24 Jun 2023 13:50:55 -0400 [thread overview]
Message-ID: <20230624135056.263e0ba9@rorschach.local.home> (raw)
In-Reply-To: <20230623220959.6461cc02@rorschach.local.home>
Linus,
On Fri, 23 Jun 2023 22:09:59 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> The code that does the write is basically something being monitored by
> something else that will tell it to start writing. But that something
> else could have the buffer disabled for writes. The use case for this
> is to disable the buffer, enable all the trace events you care about,
> and then enabled the buffer which is the same as enabling all events at
> the same time to get a more coherent trace.
Are you fine with the above explanation? The thing is, writes that are
dropped due to the buffer being disabled shouldn't be a concern of the
producer. It's the consumer that controls that. This is the same
behavior that is used by internal kernel trace events, and we wanted to
keep it consistent.
Would you like me to resend the pull request with an updated change log?
-- Steve
next prev parent reply other threads:[~2023-06-24 17:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 19:29 Steven Rostedt
2023-06-23 23:21 ` Linus Torvalds
2023-06-24 2:09 ` Steven Rostedt
2023-06-24 17:50 ` Steven Rostedt [this message]
2023-06-25 23:04 ` Linus Torvalds
2023-06-26 6:07 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230624135056.263e0ba9@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=beaub@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=sunliming@kylinos.cn \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®