From: Yunlei He <heyunlei@oppo.com>
To: jaegeuk@kernel.org, chao@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Yunlei He <heyunlei@oppo.com>
Subject: [f2fs-dev][PATCH 2/2 v2] f2fs: truncate pages if move file range success
Date: Mon, 26 Jun 2023 00:06:27 +0800 [thread overview]
Message-ID: <20230625160627.4112651-2-heyunlei@oppo.com> (raw)
In-Reply-To: <20230625160627.4112651-1-heyunlei@oppo.com>
If move file range success, it should remove old data from
src and dst page cache.
Signed-off-by: Yunlei He <heyunlei@oppo.com>
---
v2:
-truncate pages with filemap invalidate lock
-should drop extent cache
fs/f2fs/file.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 5af7e57b6140..7b3b333f96f5 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -2869,7 +2869,13 @@ static int f2fs_move_file_range(struct file *file_in, loff_t pos_in,
goto out_src;
}
+ filemap_invalidate_lock_two(src->i_mapping, dst->i_mapping);
+ truncate_pagecache_range(src, pos_in, pos_in + len - 1);
+ truncate_pagecache_range(dst, pos_out, pos_out + len - 1);
+
f2fs_lock_op(sbi);
+ f2fs_drop_extent_tree(src);
+ f2fs_drop_extent_tree(dst);
ret = __exchange_data_block(src, dst, pos_in >> F2FS_BLKSIZE_BITS,
pos_out >> F2FS_BLKSIZE_BITS,
len >> F2FS_BLKSIZE_BITS, false);
@@ -2881,14 +2887,24 @@ static int f2fs_move_file_range(struct file *file_in, loff_t pos_in,
f2fs_i_size_write(dst, dst_osize);
}
f2fs_unlock_op(sbi);
+ filemap_invalidate_unlock_two(src->i_mapping, dst->i_mapping);
if (src != dst)
f2fs_up_write(&F2FS_I(dst)->i_gc_rwsem[WRITE]);
out_src:
f2fs_up_write(&F2FS_I(src)->i_gc_rwsem[WRITE]);
+
if (ret)
goto out_unlock;
+ /* write out all moved pages, if possible */
+ filemap_invalidate_lock_two(src->i_mapping, dst->i_mapping);
+ filemap_write_and_wait_range(dst->i_mapping,
+ pos_out, pos_out + len);
+ truncate_pagecache_range(dst, pos_out, pos_out + len - 1);
+ truncate_pagecache_range(src, pos_in, pos_in + len - 1);
+ filemap_invalidate_unlock_two(src->i_mapping, dst->i_mapping);
+
src->i_mtime = src->i_ctime = current_time(src);
f2fs_mark_inode_dirty_sync(src, false);
if (src != dst) {
--
2.40.1
next prev parent reply other threads:[~2023-06-25 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-25 16:06 [f2fs-dev][PATCH 1/2 v2] f2fs: update mtime and ctime in move file range method Yunlei He
2023-06-25 16:06 ` Yunlei He [this message]
2023-06-26 9:15 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230625160627.4112651-2-heyunlei@oppo.com \
--to=heyunlei@oppo.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®