From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E500EB64DD for ; Tue, 27 Jun 2023 04:35:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229987AbjF0EfZ (ORCPT ); Tue, 27 Jun 2023 00:35:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229750AbjF0EfU (ORCPT ); Tue, 27 Jun 2023 00:35:20 -0400 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CB521718 for ; Mon, 26 Jun 2023 21:35:19 -0700 (PDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-573cacf4804so54577697b3.1 for ; Mon, 26 Jun 2023 21:35:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687840518; x=1690432518; h=to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=J/QPCwex7ROy04p3TgGaGQBp0Wh9htCcujKoYqvqbhU=; b=YIEtfV/tr8KxF7V5aLrfZcniPuQsJM5gIdAoE4WgszjGdqZj/+0XoWec3H4jZsxwTc d307Xf2HU3yt7LYA8UabPMG9pbguL2zus8l0v+IP62n6pyEFmEPbHMoLCh/8aZwA+F1G 10FmVM6LqW8okifrUT6mL66+rGSkX8QbXuPZamxpxgmM9Qt0KaCKnf03Dp7AVrI1WKOB df/+FGralqpiwD1YHivBoDep8xn5io5pPK+/3RKivPOzF8d1oDawUKN45c8+sHn6HAS/ /CcyjyPDded8esXmFvegflLUBB6iqJ3FF9lzYLMgL2rK1txcMcGtxYSyXX2OSkpvwwOq I/7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687840518; x=1690432518; h=to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=J/QPCwex7ROy04p3TgGaGQBp0Wh9htCcujKoYqvqbhU=; b=kLsA8Hol0fIhoXvqWn9nuMt80oxJ8KJZ3dzmw4BlaHwDOPqh6CRqF29nnFb2MUOkBw bQXpPHXH6N8ctCt0HjhH4GWyPZ1YQA65Cqt8oHzdS9Z4+nrNSWHmfSNDnS6CUM4YO9CT qlsfal3FDrMl48EcCsSBwbdpJEhszd6cghpfnkY5WGo2fiPXvxpMOZBiqDpv1xSyDfus u/pqIVzI4xP/y39vhsXvqeNRqZK1T13DZRg29RIokws+TzZJN+BpWVtJORE8eNrSNEtS XnMEJTWrPZAGxGJX+jJ6Q1lHUeN4eYFCSykMrBzSvjpm0jvlSD9JIgyjjmETOQawJ2Ny oBSA== X-Gm-Message-State: AC+VfDzIUOqY3b63sgw/IcNQ1NRAjdjj0km86spBWPHWOvuBt+o6YFfR W5dMJqncmDingWkXMHw+0UkQwr2J5n9D X-Google-Smtp-Source: ACHHUZ5IpVTstgl7l3U4JaRHaOVP1KMYuAf/ZIqCFZ/h7GWQ0amGVNA0QYNxgmMIMoHLrDxsm7vKHYX2K0VF X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:497e:a125:3cde:94f]) (user=irogers job=sendgmr) by 2002:a81:4312:0:b0:56c:fce1:7d8d with SMTP id q18-20020a814312000000b0056cfce17d8dmr13551974ywa.6.1687840518437; Mon, 26 Jun 2023 21:35:18 -0700 (PDT) Date: Mon, 26 Jun 2023 21:34:45 -0700 Message-Id: <20230627043458.662048-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.41.0.162.gfafddb0af9-goog Subject: [PATCH v1 00/13] parse-events clean up From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Athira Rajeev , Kan Liang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove some tokens the lexer never produces. Ensure abort paths set an error. Previously scanning all PMUs meant bad events could fail with an invalid token, detect this at the point parsing for a PMU fails and add error strings. Try to be consistent in using YYNOMEM for memory failures and YYABORT for bad input. Ian Rogers (13): perf parse-events: Remove unused PE_PMU_EVENT_FAKE token perf parse-events: Remove unused PE_KERNEL_PMU_EVENT token perf parse-events: Remove two unused tokens perf parse-events: Add more comments to parse_events_state perf parse-events: Avoid regrouped warning for wild card events perf parse-event: Add memory allocation test for name terms perf parse-events: Separate YYABORT and YYNOMEM cases perf parse-events: Move instances of YYABORT to YYNOMEM perf parse-events: Separate ENOMEM memory handling perf parse-events: Additional error reporting perf parse-events: Populate error column for BPF events perf parse-events: Improve location for add pmu perf parse-events: Remove ABORT_ON tools/perf/tests/bpf.c | 2 +- tools/perf/util/parse-events.c | 95 +++++---- tools/perf/util/parse-events.h | 20 +- tools/perf/util/parse-events.y | 351 +++++++++++++++++---------------- 4 files changed, 256 insertions(+), 212 deletions(-) -- 2.41.0.162.gfafddb0af9-goog