From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 76D2EEB64DC
	for <linux-kernel@archiver.kernel.org>; Tue, 27 Jun 2023 19:31:00 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229982AbjF0Ta7 (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 27 Jun 2023 15:30:59 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49100 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229487AbjF0Tav (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 27 Jun 2023 15:30:51 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF40019B5
        for <linux-kernel@vger.kernel.org>; Tue, 27 Jun 2023 12:30:50 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
         key-exchange X25519 server-signature RSA-PSS (2048 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id 4DB2F6120E
        for <linux-kernel@vger.kernel.org>; Tue, 27 Jun 2023 19:30:48 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A0C6C433C8;
        Tue, 27 Jun 2023 19:30:47 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org;
        s=korg; t=1687894247;
        bh=qyL7k4x2MyCgP1gFHf5PfFyJg9/NSQ4dtkkM96Ww+3c=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=qRbNX/YF7zcQlP1FGxbD2rHq2rIsxYzfvJ9ST87O1hP+xSY00uHWo0IRMrwCC4XSM
         BjGafaZFLnMVCtW7D8y7MNFcB+k//AAkn2R822RwFhTfnuNnsPEHtWsOac5GVF8zI+
         z4n5yHU5tOF0quf+S+S0sHiZ+iKHEM5/8N1FvqyU=
Date:   Tue, 27 Jun 2023 12:30:46 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Miaohe Lin <linmiaohe@huawei.com>
Cc:     <naoya.horiguchi@nec.com>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: memory-failure: fix unexpected return value in
 soft_offline_page()
Message-Id: <20230627123046.ef7e791208214bbfecd71e42@linux-foundation.org>
In-Reply-To: <20230627112808.1275241-1-linmiaohe@huawei.com>
References: <20230627112808.1275241-1-linmiaohe@huawei.com>
X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 27 Jun 2023 19:28:08 +0800 Miaohe Lin <linmiaohe@huawei.com> wrote:

> When page_handle_poison() fails to handle the hugepage or free page in
> retry path, soft_offline_page() will return 0 while -EBUSY is expected
> in this case.

What are the user visible effects of the bug?

> Fixes: b94e02822deb ("mm,hwpoison: try to narrow window race for free pages")
>
> ...
>
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -2737,10 +2737,13 @@ int soft_offline_page(unsigned long pfn, int flags)
>  	if (ret > 0) {
>  		ret = soft_offline_in_use_page(page);
>  	} else if (ret == 0) {
> -		if (!page_handle_poison(page, true, false) && try_again) {
> -			try_again = false;
> -			flags &= ~MF_COUNT_INCREASED;
> -			goto retry;
> +		if (!page_handle_poison(page, true, false)) {
> +			if (try_again) {
> +				try_again = false;
> +				flags &= ~MF_COUNT_INCREASED;
> +				goto retry;
> +			}
> +			ret = -EBUSY;
>  		}
>  	}