From: Utkarsh Patel <utkarsh.h.patel@intel.com>
To: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
heikki.krogerus@linux.intel.com, pmalani@chromium.org,
bleung@chromium.org
Cc: Utkarsh Patel <utkarsh.h.patel@intel.com>
Subject: [PATCH v2 1/2] platform/chrome: cros_ec_typec: Configure Retimer cable type
Date: Wed, 28 Jun 2023 10:37:26 -0700 [thread overview]
Message-ID: <20230628173727.701140-2-utkarsh.h.patel@intel.com> (raw)
In-Reply-To: <20230628173727.701140-1-utkarsh.h.patel@intel.com>
Connector class driver only configure cable type active or passive.
With this change it will also configure if the cable type is retimer or
redriver if required by AP. This detail will be provided as a part of
cable discover mode VDO.
Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com>
---
Changes in v2:
- Implemented use of cable discover mode vdo.
- Removed adittional changes to host command.
---
---
drivers/platform/chrome/cros_ec_typec.c | 33 ++++++++++++++++++++++++-
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index 25f9767c28e8..557f396d1c00 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -406,6 +406,25 @@ static int cros_typec_usb_safe_state(struct cros_typec_port *port)
return ret;
}
+static int cros_typec_get_cable_vdo(struct cros_typec_data *typec, int port_num,
+ uint16_t svid)
+{
+ struct cros_typec_port *port = typec->ports[port_num];
+ struct list_head *head = &port->plug_mode_list;
+ struct cros_typec_altmode_node *node;
+
+ list_for_each_entry(node, head, list) {
+ if (node->amode->svid == svid)
+ break;
+ }
+
+ if (node->amode->svid != svid)
+ return 0;
+
+ return node->amode->vdo;
+}
+
+
/*
* Spoof the VDOs that were likely communicated by the partner for TBT alt
* mode.
@@ -416,6 +435,7 @@ static int cros_typec_enable_tbt(struct cros_typec_data *typec,
{
struct cros_typec_port *port = typec->ports[port_num];
struct typec_thunderbolt_data data;
+ uint32_t cable_vdo;
int ret;
if (typec->pd_ctrl_ver < 2) {
@@ -442,6 +462,11 @@ static int cros_typec_enable_tbt(struct cros_typec_data *typec,
data.cable_mode |= TBT_SET_CABLE_ROUNDED(pd_ctrl->cable_gen);
+ cable_vdo = cros_typec_get_cable_vdo(typec, port_num, USB_TYPEC_TBT_SID);
+
+ if (cable_vdo & TBT_CABLE_RETIMER)
+ data.cable_mode |= TBT_CABLE_RETIMER;
+
/* Enter Mode VDO */
data.enter_vdo = TBT_SET_CABLE_SPEED(pd_ctrl->cable_speed);
@@ -513,17 +538,23 @@ static int cros_typec_enable_usb4(struct cros_typec_data *typec,
{
struct cros_typec_port *port = typec->ports[port_num];
struct enter_usb_data data;
+ uint32_t cable_vdo;
data.eudo = EUDO_USB_MODE_USB4 << EUDO_USB_MODE_SHIFT;
+ cable_vdo = cros_typec_get_cable_vdo(typec, port_num, USB_TYPEC_TBT_SID);
+
/* Cable Speed */
data.eudo |= pd_ctrl->cable_speed << EUDO_CABLE_SPEED_SHIFT;
/* Cable Type */
if (pd_ctrl->control_flags & USB_PD_CTRL_OPTICAL_CABLE)
data.eudo |= EUDO_CABLE_TYPE_OPTICAL << EUDO_CABLE_TYPE_SHIFT;
- else if (pd_ctrl->control_flags & USB_PD_CTRL_ACTIVE_CABLE)
+ else if (cable_vdo & TBT_CABLE_RETIMER)
data.eudo |= EUDO_CABLE_TYPE_RE_TIMER << EUDO_CABLE_TYPE_SHIFT;
+ else if (!(cable_vdo & TBT_CABLE_RETIMER) &&
+ (pd_ctrl->control_flags & USB_PD_CTRL_ACTIVE_CABLE))
+ data.eudo |= EUDO_CABLE_TYPE_RE_DRIVER << EUDO_CABLE_TYPE_SHIFT;
data.active_link_training = !!(pd_ctrl->control_flags &
USB_PD_CTRL_ACTIVE_LINK_UNIDIR);
--
2.25.1
next prev parent reply other threads:[~2023-06-28 17:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 17:37 [PATCH v2 0/2] Add support to configure active retimer cable Utkarsh Patel
2023-06-28 17:37 ` Utkarsh Patel [this message]
2023-06-29 17:38 ` [PATCH v2 1/2] platform/chrome: cros_ec_typec: Configure Retimer cable type Prashant Malani
2023-06-30 0:43 ` Patel, Utkarsh H
2023-06-28 17:37 ` [PATCH v2 2/2] usb: typec: intel_pmc_mux: Configure Active and Retimer Cable type Utkarsh Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230628173727.701140-2-utkarsh.h.patel@intel.com \
--to=utkarsh.h.patel@intel.com \
--cc=bleung@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®