mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Juerg Haefliger <juerg.haefliger@canonical.com>
Cc: jk@ozlabs.org, joel@jms.id.au, alistair@popple.id.au,
	eajames@linux.ibm.com, linux-fsi@lists.ozlabs.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fsi: master-ast-cf: Add MODULE_FIRMWARE macro
Date: Wed, 28 Jun 2023 08:47:12 +0200	[thread overview]
Message-ID: <2023062852-spirited-excitable-dabc@gregkh> (raw)
In-Reply-To: <20230616122040.1035518-1-juerg.haefliger@canonical.com>

On Fri, Jun 16, 2023 at 02:20:40PM +0200, Juerg Haefliger wrote:
> The module loads firmware so add a MODULE_FIRMWARE macro to provide that
> information via modinfo.
> 
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> ---
>  drivers/fsi/fsi-master-ast-cf.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/fsi/fsi-master-ast-cf.c b/drivers/fsi/fsi-master-ast-cf.c
> index 5f608ef8b53c..1316bfd121fe 100644
> --- a/drivers/fsi/fsi-master-ast-cf.c
> +++ b/drivers/fsi/fsi-master-ast-cf.c
> @@ -1441,3 +1441,5 @@ static struct platform_driver fsi_master_acf = {
>  
>  module_platform_driver(fsi_master_acf);
>  MODULE_LICENSE("GPL");
> +
> +MODULE_FIRMWARE(FW_FILE_NAME);

No need for the extra blank line, right?

And what commit id does this fix?

thanks,

greg k-h

  reply	other threads:[~2023-06-28  8:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-16 12:20 Juerg Haefliger
2023-06-28  6:47 ` Greg KH [this message]
2023-06-28  7:29   ` Juerg Haefliger
2023-06-28  7:37     ` Greg KH
2023-06-28  9:50 ` [PATCH v2] " Juerg Haefliger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023062852-spirited-excitable-dabc@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=alistair@popple.id.au \
    --cc=eajames@linux.ibm.com \
    --cc=jk@ozlabs.org \
    --cc=joel@jms.id.au \
    --cc=juerg.haefliger@canonical.com \
    --cc=linux-fsi@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®