From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A792FEB64D7 for ; Thu, 29 Jun 2023 00:35:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231303AbjF2AfA (ORCPT ); Wed, 28 Jun 2023 20:35:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230492AbjF2Ae5 (ORCPT ); Wed, 28 Jun 2023 20:34:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C75152102 for ; Wed, 28 Jun 2023 17:34:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2F754614B0 for ; Thu, 29 Jun 2023 00:34:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35EAAC433CA; Thu, 29 Jun 2023 00:34:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687998894; bh=H5CexLdNVkHoiH7McrTGx6XWtj4Sm7MNlNrvQTM04Nc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Q2z1YaCRJUqJUKiwHVcwNrKfzi/x330n6aqNeBwfW5WSzGNUCklsM/JMN0purdjja PEnbAqroqQgScEtFDBy3XDoIN0aLUFS4hCGQfe/W4BByo63ESQprTCXYSFHzjRGOsM EU6X8yTL/BCYgbxqbRvsH4n7I4sz961za9cCv4guNUmSGDwgVHMEq5HwlFzydshA+9 NnABe9yorsd3019bSA667hPI8cYCWiNqntdtv79HOGwiA34QYuNca1GHy9sVzs9Psn l0Qd3eOXHu8JpO3ci63nJybVq26h6eWZf9DgFFZYZS/HY8Yr87H/7Z2uerkBq195Pe eB1BtgypUvvpQ== Date: Thu, 29 Jun 2023 09:34:50 +0900 From: Masami Hiramatsu (Google) To: Masami Hiramatsu (Google) Cc: Linus Torvalds , Akanksha J N , Steven Rostedt , linux-kernel@vger.kernel.org Subject: Re: [GIT PULL] Probes update for v6.5 Message-Id: <20230629093450.376e43232c28c82624da622f@kernel.org> In-Reply-To: <20230628005818.c8df3a79955c7585d979419b@kernel.org> References: <20230628005818.c8df3a79955c7585d979419b@kernel.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, Oops, I found the subject format was wrong. Let me resend it. On Wed, 28 Jun 2023 00:58:18 +0900 Masami Hiramatsu (Google) wrote: > Hi Linus, > > Probes updates for v6.5: > > - fprobe: Pass return address to the fprobe entry/exit callbacks so that > the callbacks don't need to analyze pt_regs/stack to find the function > return address. > > - kprobe events: cleanup usage of TPARG_FL_FENTRY and TPARG_FL_RETURN > flags so that those are not set at once. > > - fprobe events: > . Add a new fprobe events for tracing arbitrary function entry and > exit as a trace event. > . Add a new tracepoint events for tracing raw tracepoint as a trace > event. This allows user to trace non user-exposed tracepoints. > . Move eprobe's event parser code into probe event common file. > . Introduce BTF (BPF type format) support to kernel probe (kprobe, > fprobe and tracepoint probe) events so that user can specify traced > function arguments by name. This also applies the type of argument > when fetching the argument. > . Introduce '$arg*' wildcard support if BTF is available. This expands > the '$arg*' meta argument to all function argument automatically. > . Check the return value types by BTF. If the function returns 'void', > '$retval' is rejected. > . Add some selftest script for fprobe events, tracepoint events and > BTF support. > . Update documentation about the fprobe events. > . Some fixes for above features, document and selftests. > > - selftests for ftrace (except for new fprobe events): > . Add a test case for multiple consecutive probes in a function which > checks if ftrace based kprobe, optimized kprobe and normal kprobe > can be defined in the same target function. > . Add a test case for optimized probe, which checks whether kprobe > can be optimized or not. > > > Please pull the latest probes-v6.5 tree, which can be found at: > > > git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git > probes-v6.5 > > Tag SHA1: 08bb7e2de7f32619cd100419e719ef96d6cf0aab > Head SHA1: 53431798f4bb60d214ae1ec4a79eefdd414f577b > > > Akanksha J N (2): > selftests/ftrace: Add new test case which adds multiple consecutive probes in a function > selftests/ftrace: Add new test case which checks for optimized probes > > Masami Hiramatsu (Google) (15): > fprobe: Pass return address to the handlers > tracing/probes: Avoid setting TPARG_FL_FENTRY and TPARG_FL_RETURN > tracing/probes: Add fprobe events for tracing function entry and exit. > selftests/ftrace: Add fprobe related testcases > tracing/probes: Add tracepoint support on fprobe_events > tracing/probes: Move event parameter fetching code to common parser > tracing/probes: Support function parameters if BTF is available > tracing/probes: Add $arg* meta argument for all function args > tracing/probes: Add BTF retval type support > selftests/ftrace: Add tracepoint probe test case > selftests/ftrace: Add BTF arguments test cases > Documentation: tracing/probes: Add fprobe event tracing document > tracing/probes: Fix to return NULL and keep using current argc > Documentation: Fix typo of reference file name > tracing/probes: Fix tracepoint event with $arg* to fetch correct argument > > ---- > Documentation/trace/fprobetrace.rst | 188 +++ > Documentation/trace/index.rst | 1 + > Documentation/trace/kprobetrace.rst | 2 + > include/linux/fprobe.h | 11 +- > include/linux/rethook.h | 2 +- > include/linux/trace_events.h | 3 + > include/linux/tracepoint-defs.h | 1 + > include/linux/tracepoint.h | 5 + > kernel/kprobes.c | 1 + > kernel/trace/Kconfig | 26 + > kernel/trace/Makefile | 1 + > kernel/trace/bpf_trace.c | 6 +- > kernel/trace/fprobe.c | 17 +- > kernel/trace/rethook.c | 3 +- > kernel/trace/trace.c | 13 +- > kernel/trace/trace.h Linus, > > Probes updates for v6.5: > > - fprobe: Pass return address to the fprobe entry/exit callbacks so that > the callbacks don't need to analyze pt_regs/stack to find the function > return address. > > - kprobe events: cleanup usage of TPARG_FL_FENTRY and TPARG_FL_RETURN > flags so that those are not set at once. > > - fprobe events: > . Add a new fprobe events for tracing arbitrary function entry and > exit as a trace event. > . Add a new tracepoint events for tracing raw tracepoint as a trace > event. This allows user to trace non user-exposed tracepoints. > . Move eprobe's event parser code into probe event common file. > . Introduce BTF (BPF type format) support to kernel probe (kprobe, > fprobe and tracepoint probe) events so that user can specify traced > function arguments by name. This also applies the type of argument > when fetching the argument. > . Introduce '$arg*' wildcard support if BTF is available. This expands > the '$arg*' meta argument to all function argument automatically. > . Check the return value types by BTF. If the function returns 'void', > '$retval' is rejected. > . Add some selftest script for fprobe events, tracepoint events and > BTF support. > . Update documentation about the fprobe events. > . Some fixes for above features, document and selftests. > > - selftests for ftrace (except for new fprobe events): > . Add a test case for multiple consecutive probes in a function which > checks if ftrace based kprobe, optimized kprobe and normal kprobe > can be defined in the same target function. > . Add a test case for optimized probe, which checks whether kprobe > can be optimized or not. > > > Please pull the latest probes-v6.5 tree, which can be found at: > > > git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git > probes-v6.5 > > Tag SHA1: 08bb7e2de7f32619cd100419e719ef96d6cf0aab > Head SHA1: 53431798f4bb60d214ae1ec4a79eefdd414f577b > > > Akanksha J N (2): > selftests/ftrace: Add new test case which adds multiple consecutive probes in a function > selftests/ftrace: Add new test case which checks for optimized probes > > Masami Hiramatsu (Google) (15): > fprobe: Pass return address to the handlers > tracing/probes: Avoid setting TPARG_FL_FENTRY and TPARG_FL_RETURN > tracing/probes: Add fprobe events for tracing function entry and exit. > selftests/ftrace: Add fprobe related testcases > tracing/probes: Add tracepoint support on fprobe_events > tracing/probes: Move event parameter fetching code to common parser > tracing/probes: Support function parameters if BTF is available > tracing/probes: Add $arg* meta argument for all function args > tracing/probes: Add BTF retval type support > selftests/ftrace: Add tracepoint probe test case > selftests/ftrace: Add BTF arguments test cases > Documentation: tracing/probes: Add fprobe event tracing document > tracing/probes: Fix to return NULL and keep using current argc > Documentation: Fix typo of reference file name > tracing/probes: Fix tracepoint event with $arg* to fetch correct argument > > ---- > Documentation/trace/fprobetrace.rst | 188 +++ > Documentation/trace/index.rst | 1 + > Documentation/trace/kprobetrace.rst | 2 + > include/linux/fprobe.h | 11 +- > include/linux/rethook.h | 2 +- > include/linux/trace_events.h | 3 + > include/linux/tracepoint-defs.h | 1 + > include/linux/tracepoint.h | 5 + > kernel/kprobes.c | 1 + > kernel/trace/Kconfig | 26 + > kernel/trace/Makefile | 1 + > kernel/trace/bpf_trace.c | 6 +- > kernel/trace/fprobe.c | 17 +- > kernel/trace/rethook.c | 3 +- > kernel/trace/trace.c | 13 +- > kernel/trace/trace.h | 11 + > kernel/trace/trace_eprobe.c | 44 +- > kernel/trace/trace_fprobe.c | 1199 ++++++++++++++++++++ > kernel/trace/trace_kprobe.c | 35 +- > kernel/trace/trace_probe.c | 659 +++++++++-- > kernel/trace/trace_probe.h | 49 +- > kernel/trace/trace_uprobe.c | 8 +- > lib/test_fprobe.c | 10 +- > samples/fprobe/fprobe_example.c | 6 +- > .../ftrace/test.d/dynevent/add_remove_btfarg.tc | 58 + > .../ftrace/test.d/dynevent/add_remove_fprobe.tc | 26 + > .../ftrace/test.d/dynevent/add_remove_tprobe.tc | 27 + > .../ftrace/test.d/dynevent/fprobe_syntax_errors.tc | 111 ++ > .../ftrace/test.d/dynevent/tprobe_syntax_errors.tc | 82 ++ > .../ftrace/test.d/kprobe/kprobe_insn_boundary.tc | 19 + > .../ftrace/test.d/kprobe/kprobe_opt_types.tc | 34 + > .../ftrace/test.d/kprobe/kprobe_syntax_errors.tc | 16 +- > 32 files changed, 2510 insertions(+), 164 deletions(-) > create mode 100644 Documentation/trace/fprobetrace.rst > create mode 100644 kernel/trace/trace_fprobe.c > create mode 100644 tools/testing/selftests/ftrace/test.d/dynevent/add_remove_btfarg.tc > create mode 100644 tools/testing/selftests/ftrace/test.d/dynevent/add_remove_fprobe.tc > create mode 100644 tools/testing/selftests/ftrace/test.d/dynevent/add_remove_tprobe.tc > create mode 100644 tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc > create mode 100644 tools/testing/selftests/ftrace/test.d/dynevent/tprobe_syntax_errors.tc > create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_insn_boundary.tc > create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_opt_types.tc | 11 + > kernel/trace/trace_eprobe.c | 44 +- > kernel/trace/trace_fprobe.c | 1199 ++++++++++++++++++++ > kernel/trace/trace_kprobe.c | 35 +- > kernel/trace/trace_probe.c | 659 +++++++++-- > kernel/trace/trace_probe.h | 49 +- > kernel/trace/trace_uprobe.c | 8 +- > lib/test_fprobe.c | 10 +- > samples/fprobe/fprobe_example.c | 6 +- > .../ftrace/test.d/dynevent/add_remove_btfarg.tc | 58 + > .../ftrace/test.d/dynevent/add_remove_fprobe.tc | 26 + > .../ftrace/test.d/dynevent/add_remove_tprobe.tc | 27 + > .../ftrace/test.d/dynevent/fprobe_syntax_errors.tc | 111 ++ > .../ftrace/test.d/dynevent/tprobe_syntax_errors.tc | 82 ++ > .../ftrace/test.d/kprobe/kprobe_insn_boundary.tc | 19 + > .../ftrace/test.d/kprobe/kprobe_opt_types.tc | 34 + > .../ftrace/test.d/kprobe/kprobe_syntax_errors.tc | 16 +- > 32 files changed, 2510 insertions(+), 164 deletions(-) > create mode 100644 Documentation/trace/fprobetrace.rst > create mode 100644 kernel/trace/trace_fprobe.c > create mode 100644 tools/testing/selftests/ftrace/test.d/dynevent/add_remove_btfarg.tc > create mode 100644 tools/testing/selftests/ftrace/test.d/dynevent/add_remove_fprobe.tc > create mode 100644 tools/testing/selftests/ftrace/test.d/dynevent/add_remove_tprobe.tc > create mode 100644 tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc > create mode 100644 tools/testing/selftests/ftrace/test.d/dynevent/tprobe_syntax_errors.tc > create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_insn_boundary.tc > create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_opt_types.tc > > -- > Masami Hiramatsu (Google) -- Masami Hiramatsu (Google)