From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99ABDEB64DC for ; Thu, 29 Jun 2023 15:24:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232394AbjF2PYU (ORCPT ); Thu, 29 Jun 2023 11:24:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232667AbjF2PXz (ORCPT ); Thu, 29 Jun 2023 11:23:55 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B08F4AA; Thu, 29 Jun 2023 08:23:54 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1D2202183F; Thu, 29 Jun 2023 15:23:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1688052233; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SDMETg5+Q3nEygFwFrRecOB6bMUHUq26nIKOB3envt4=; b=nqNFB+A7+ApsQ1xfUwMWxil7lk30Gcq7FyDnTMReKIyDKELB7l9UhvwWH2QTUJ2MNubHu1 npFDoU3yCQz4bGeJUgtzcSIz0XUfmRTbgj94uqst9x7m7tAMDBteU8g6I1wTy/d2BHf2nW PLxbgSkLx5dWY4kP4UGccZ97aILd8ZY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1688052233; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SDMETg5+Q3nEygFwFrRecOB6bMUHUq26nIKOB3envt4=; b=XG2k8enTLU2k8/k1h5IOwUHZlUhSTcYpUW3DBqfJMomwqXa1trHM3g0ImCKvrI+nmruxk8 HXZoSu+RgvD4ZKBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EA14413905; Thu, 29 Jun 2023 15:23:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JARMOAiinWRQNAAAMHmgww (envelope-from ); Thu, 29 Jun 2023 15:23:52 +0000 Date: Thu, 29 Jun 2023 17:17:24 +0200 From: David Sterba To: Colin Ian King Cc: Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] btrfs: scrub: remove redundant division of stripe_nr Message-ID: <20230629151724.GL16168@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <20230621130937.2676434-1-colin.i.king@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230621130937.2676434-1-colin.i.king@gmail.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 21, 2023 at 02:09:37PM +0100, Colin Ian King wrote: > Variable stripe_nr is being divided by map->num_stripes however the > result is never read. The division and assignment are redundant and > can be removed. Cleans up clang scan build warning: > > fs/btrfs/scrub.c:1264:3: warning: Value stored to 'stripe_nr' is > never read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King Added to misc-next, thanks.