From: Rodolfo Giometti <giometti@enneenne.com>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Charlie Johnston <charlie.johnston@ni.com>,
Rodolfo Giometti <giometti@enneenne.com>
Subject: [PATCH 1/2] include/uapi pps.h: increase PPS_MAX_SOURCES value
Date: Fri, 30 Jun 2023 09:18:25 +0200 [thread overview]
Message-ID: <20230630071826.105501-1-giometti@enneenne.com> (raw)
From: Charlie Johnston <charlie.johnston@ni.com>
For consistency with what others use for minors, this change sets
PPS_MAX_SOURCES to MINORMASK.
The PPS_MAX_SOURCES value is currently set to 16. In some cases this
was not sufficient for a system. For example, a system with multiple
(4+) PCIe cards each with 4 PTP-capable ethernet interfaces could run
out of the available PPS major:minors if each interface registers a
PPS source.
Signed-off-by: Charlie Johnston <charlie.johnston@ni.com>
Acked-by: Rodolfo Giometti <giometti@enneenne.com>
---
include/uapi/linux/pps.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/pps.h b/include/uapi/linux/pps.h
index 009ebcd8ced5..90f2e86020ba 100644
--- a/include/uapi/linux/pps.h
+++ b/include/uapi/linux/pps.h
@@ -26,7 +26,7 @@
#include <linux/types.h>
#define PPS_VERSION "5.3.6"
-#define PPS_MAX_SOURCES 16 /* should be enough... */
+#define PPS_MAX_SOURCES MINORMASK
/* Implementation note: the logical states ``assert'' and ``clear''
* are implemented in terms of the chip register, i.e. ``assert''
--
2.34.1
next reply other threads:[~2023-06-30 7:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 7:18 Rodolfo Giometti [this message]
2023-06-30 7:18 ` [PATCH 2/2] include/uapi pps.h: drop not needed PPS_MAX_SOURCES define Rodolfo Giometti
2023-06-30 7:31 ` Greg Kroah-Hartman
2023-06-30 7:50 ` Rodolfo Giometti
2023-06-30 12:53 ` Greg Kroah-Hartman
2023-06-30 13:29 ` Rodolfo Giometti
2023-07-03 13:38 ` Greg Kroah-Hartman
2023-07-03 14:47 ` Rodolfo Giometti
2023-07-17 15:52 ` Charlie Johnston
2023-07-18 7:47 ` Rodolfo Giometti
2023-08-08 17:58 ` Charlie Johnston
2023-08-09 7:12 ` Rodolfo Giometti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230630071826.105501-1-giometti@enneenne.com \
--to=giometti@enneenne.com \
--cc=charlie.johnston@ni.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®