From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF6D2EB64D7 for ; Fri, 30 Jun 2023 09:26:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232816AbjF3J0l (ORCPT ); Fri, 30 Jun 2023 05:26:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232798AbjF3J0g (ORCPT ); Fri, 30 Jun 2023 05:26:36 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 878913585; Fri, 30 Jun 2023 02:26:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=A7ZndEt01QEZmkLMkpapRia2Tu8Y/tv4dlx01OgRstM=; b=oafGXmMGFJt3bsEOzR38QGYprG LNFkJjjxFfrmiWLryi6zOAcgKaY1wXL2D7SMBGMsbfy5PSOHUZiWFQH1noAJfkpWU8K79s3cflx01 K0oOO9cjX5PFKMcbM5lowEZQyEOeGJ85XHGlrJiPH46Pj+sgxj/ON9oEMsW8YQmvgBz2w3MJm4fJD P87HMXE5fYGq5t36C1Bg45k6ZuOL3hbq+VCzqo9ef32LN0LuZcRVEmxZz1szSkcnvgMUQFgARiyZP /sWCJxggP8hn9ce8+Xa8y5hTM7l/L8Og1YgC++eWuMPD4scs/iOo5fTEXThcRMUXoEjagHDifcaW2 tf4fyGhA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qFAOO-007wMo-16; Fri, 30 Jun 2023 09:26:18 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id EA3A3300118; Fri, 30 Jun 2023 11:26:15 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id D9AAD245D3645; Fri, 30 Jun 2023 11:26:15 +0200 (CEST) Date: Fri, 30 Jun 2023 11:26:15 +0200 From: Peter Zijlstra To: "Huang, Kai" Cc: "kvm@vger.kernel.org" , "Raj, Ashok" , "Hansen, Dave" , "david@redhat.com" , "bagasdotme@gmail.com" , "Luck, Tony" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "linux-kernel@vger.kernel.org" , "Christopherson,, Sean" , "mingo@redhat.com" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "tglx@linutronix.de" , "kirill.shutemov@linux.intel.com" , "Chatre, Reinette" , "Yamahata, Isaku" , "nik.borisov@suse.com" , "hpa@zytor.com" , "Shahar, Sagi" , "imammedo@redhat.com" , "bp@alien8.de" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" , "x86@kernel.org" Subject: Re: [PATCH v12 07/22] x86/virt/tdx: Add skeleton to enable TDX on demand Message-ID: <20230630092615.GD2533791@hirez.programming.kicks-ass.net> References: <104d324cd68b12e14722ee5d85a660cccccd8892.1687784645.git.kai.huang@intel.com> <20230628131717.GE2438817@hirez.programming.kicks-ass.net> <0c9639db604a0670eeae5343d456e43d06b35d39.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0c9639db604a0670eeae5343d456e43d06b35d39.camel@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 29, 2023 at 12:10:00AM +0000, Huang, Kai wrote: > On Wed, 2023-06-28 at 15:17 +0200, Peter Zijlstra wrote: > > On Tue, Jun 27, 2023 at 02:12:37AM +1200, Kai Huang wrote: > > > +EXPORT_SYMBOL_GPL(tdx_cpu_enable); > > > > I can't find a single caller of this.. why is this exported? > > It's for KVM TDX patch to use, which isn't in this series. > > I'll remove the export. KVM TDX series can export it. Fair enough; where will the KVM TDX series call this? Earlier there was talk about doing it at kvm module load time -- but I objected (and still do object) to that. What's the current plan?