From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Dave Wysochanski <dwysocha@redhat.com>,
Ronnie Sahlberg <lsahlber@redhat.com>,
Pavel Shilovsky <pshilov@microsoft.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ajay Kaher <akaher@vmware.com>
Subject: Re: Buggy rwsem locking code in fs/smb/client/file.c
Date: Mon, 3 Jul 2023 20:28:59 +0200 [thread overview]
Message-ID: <20230703182859.GO4253@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20230703114318.1576ea24@rorschach.local.home>
On Mon, Jul 03, 2023 at 11:43:18AM -0400, Steven Rostedt wrote:
> I just reviewed a patch that copied a solution from
> fs/smb/client/file.c (original was fs/cifs/file.c), which is really
> just hiding a bug. And because this code could have possibly caused
> this buggy solution to be repeated, I believe it should be fixed,
> before others use it as precedent in other areas of the kernel.
>
> Commit d46b0da7a33dd ("cifs: Fix cifsInodeInfo lock_sem deadlock when
> reconnect occurs") has in its change log:
Oh man, that's .... I gotta go buy a new WTF'o'meter again :/
prev parent reply other threads:[~2023-07-03 18:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 15:43 Steven Rostedt
2023-07-03 17:00 ` Linus Torvalds
2023-07-03 18:46 ` David Wysochanski
2023-07-03 18:28 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230703182859.GO4253@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akaher@vmware.com \
--cc=dwysocha@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=pshilov@microsoft.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®