From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE540EB64D9 for ; Tue, 4 Jul 2023 16:56:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231653AbjGDQ4P (ORCPT ); Tue, 4 Jul 2023 12:56:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231887AbjGDQ4B (ORCPT ); Tue, 4 Jul 2023 12:56:01 -0400 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04A7410D3; Tue, 4 Jul 2023 09:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:Content-Type:Mime-Version: References:In-Reply-To:Message-Id:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ir9+y5TV/whsVJj6sRiC8xzutqWRefem7WoHTqvHtKI=; b=U8sbMgm1YEOWwAXteDHcVi08zW pZ348ePZh5veZhVunmFjkXqG1xB3U7XYfkC317VK3Egw+cyNhtoqj9Lskc4BckyqQ4pgkI42AK2L5 7DJkbbV3JVt2m1biNmPPolb0J0XftRKZKDYuTGw9SUVbfTJGWOBI1fNlJh7SZPu/wJM8=; Received: from modemcable061.19-161-184.mc.videotron.ca ([184.161.19.61]:38500 helo=pettiford) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1qGjJW-0000nG-QE; Tue, 04 Jul 2023 12:55:43 -0400 Date: Tue, 4 Jul 2023 12:55:41 -0400 From: Hugo Villeneuve To: Fabio Estevam Cc: Krzysztof Kozlowski , Pierluigi Passaro , Nate Drude , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , Hugo Villeneuve , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-Id: <20230704125541.f361cab8de3faacd830418ab@hugovil.com> In-Reply-To: References: <20230704150240.2022020-1-hugo@hugovil.com> <1341ba38-35c1-1657-aed4-a3c11f584367@linaro.org> <20230704113124.f2830afe1d9df252afe5abdc@hugovil.com> <834a0679-7e0c-150f-68be-c75d7dac0bc8@linaro.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 184.161.19.61 X-SA-Exim-Mail-From: hugo@hugovil.com Subject: Re: [PATCH] arm64: dts: imx8mn-var-som-symphony: fix USB OTG X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 4 Jul 2023 13:33:10 -0300 Fabio Estevam wrote: > Adding some Variscite folks in case they can help to clarify. > > On Tue, Jul 4, 2023 at 1:20 PM Krzysztof Kozlowski > wrote: > > > > On 04/07/2023 17:31, Hugo Villeneuve wrote: > > > On Tue, 4 Jul 2023 17:08:12 +0200 > > > Krzysztof Kozlowski wrote: > > > > > >> On 04/07/2023 17:02, Hugo Villeneuve wrote: > > >>> From: Hugo Villeneuve > > >>> > > >>> USB OTG is currently broken on the Variscite Symphony EVK and imx8mn > > >>> nano SOM. > > >>> > > >>> Import changes from linux-5.15 branch of doen't giveto fix it. > > >>> > > >>> Link: https://github.com/varigit/linux-imx.git > > >>> Fixes: 7358e05bddca ("arm64: dts: imx8mn-var-som-symphony: Add Variscite Symphony board with VAR-SOM-MX8MN") > > >>> Signed-off-by: Hugo Villeneuve > > >>> --- > > >>> .../dts/freescale/imx8mn-var-som-symphony.dts | 37 ++++++++++++++++++- > > >>> 1 file changed, 35 insertions(+), 2 deletions(-) > > >>> > > >>> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts b/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts > > >>> index 406a711486da..aef89198f24c 100644 > > >>> --- a/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts > > >>> +++ b/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts > > >>> @@ -6,6 +6,7 @@ > > >>> > > >>> /dts-v1/; > > >>> > > >>> +#include > > >>> #include "imx8mn-var-som.dtsi" > > >>> > > >>> / { > > >>> @@ -104,10 +105,29 @@ extcon_usbotg1: typec@3d { > > >>> compatible = "nxp,ptn5150"; > > >>> reg = <0x3d>; > > >>> interrupt-parent = <&gpio1>; > > >>> - interrupts = <11 IRQ_TYPE_LEVEL_LOW>; > > >>> + interrupts = <11 IRQ_TYPE_NONE>; > > >> > > >> That's surprising, why? > > > > > > Hi, > > > the varigit repos log or source code has no information about this > > > particular configuration. > > > > > > In the schematics, the interrupt output pin of the PTN5150 is connected > > > to two different resistors, one of these being connected to GPIO1 pin > > > 11. But these two resistors are not assembled on any versions of the > > > board, so the interrupt pin is currently not used. > > > > OK, so there is no interrupt, but not interrupt of type none. Just drop > > the property and make it optional in the bindings. The driver however > > requires the interrupt, so I wonder how the device is going to work > > without it? > > > > Are you sure that interrupt line is not shorted instead of missing resistor? Hi, Link for schematics: https://www.variscite.com/wp-content/uploads/2019/07/Symphony-Board-Schematics.zip In the schematics, both resistors R106 (connected to PTN5150 on one side and GPIO1 pin 11 on the other size) and R131 have the text "NC" near their reference designator. And I visually confirm that R106 and R131 are not soldered on the board. However, GPIO1 pin 11 (the interrupt pin configured in the DTS) is also connected to PTN5150 pin 9 (ID), which has a simple pull-up to 3.3V. So from what I can see/deduce, the DTS interrupt pin will always be 3.3V, and never pulled to GND. Hugo.