From: Andreas Hindborg <nmi@metaspace.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-kernel@vger.kernel.org (open list),
Matias Bjorling <Matias.Bjorling@wdc.com>,
Hans Holmberg <Hans.Holmberg@wdc.com>,
Jens Axboe <axboe@kernel.dk>, Minwoo Im <minwoo.im.dev@gmail.com>,
Aravind Ramesh <Aravind.Ramesh@wdc.com>,
gost.dev@samsung.com,
linux-block@vger.kernel.org (open list:BLOCK LAYER),
Christoph Hellwig <hch@infradead.org>,
Damien Le Moal <dlemoal@kernel.org>,
Andreas Hindborg <a.hindborg@samsung.com>
Subject: [PATCH v5 1/5] ublk: add opcode offsets for DRV_IN/DRV_OUT
Date: Tue, 4 Jul 2023 18:52:05 +0200 [thread overview]
Message-ID: <20230704165209.514591-2-nmi@metaspace.dk> (raw)
In-Reply-To: <20230704165209.514591-1-nmi@metaspace.dk>
From: Andreas Hindborg <a.hindborg@samsung.com>
Ublk zoned storage support relies on DRV_IN handling for zone report.
Prepare for this change by adding offsets for the DRV_IN/DRV_OUT commands.
Also add parenthesis to existing opcodes for better macro hygiene.
Signed-off-by: Andreas Hindborg <a.hindborg@samsung.com>
---
include/uapi/linux/ublk_cmd.h | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/include/uapi/linux/ublk_cmd.h b/include/uapi/linux/ublk_cmd.h
index 4b8558db90e1..a32810c8ef2b 100644
--- a/include/uapi/linux/ublk_cmd.h
+++ b/include/uapi/linux/ublk_cmd.h
@@ -229,12 +229,16 @@ struct ublksrv_ctrl_dev_info {
__u64 reserved2;
};
-#define UBLK_IO_OP_READ 0
-#define UBLK_IO_OP_WRITE 1
-#define UBLK_IO_OP_FLUSH 2
-#define UBLK_IO_OP_DISCARD 3
-#define UBLK_IO_OP_WRITE_SAME 4
-#define UBLK_IO_OP_WRITE_ZEROES 5
+#define UBLK_IO_OP_READ (0)
+#define UBLK_IO_OP_WRITE (1)
+#define UBLK_IO_OP_FLUSH (2)
+#define UBLK_IO_OP_DISCARD (3)
+#define UBLK_IO_OP_WRITE_SAME (4)
+#define UBLK_IO_OP_WRITE_ZEROES (5)
+#define __UBLK_IO_OP_DRV_IN_START (32)
+#define __UBLK_IO_OP_DRV_IN_END (96)
+#define __UBLK_IO_OP_DRV_OUT_START (__UBLK_IO_OP_DRV_IN_END)
+#define __UBLK_IO_OP_DRV_OUT_END (160)
#define UBLK_IO_F_FAILFAST_DEV (1U << 8)
#define UBLK_IO_F_FAILFAST_TRANSPORT (1U << 9)
--
2.41.0
next prev parent reply other threads:[~2023-07-04 16:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 16:52 [PATCH v5 0/5] ublk: enable zoned storage support Andreas Hindborg
2023-07-04 16:52 ` Andreas Hindborg [this message]
2023-07-04 23:33 ` [PATCH v5 1/5] ublk: add opcode offsets for DRV_IN/DRV_OUT Damien Le Moal
2023-07-04 16:52 ` [PATCH v5 2/5] ublk: move types to shared header file Andreas Hindborg
2023-07-04 23:42 ` Damien Le Moal
2023-07-05 10:50 ` Andreas Hindborg (Samsung)
2023-07-04 16:52 ` [PATCH v5 3/5] ublk: rename driver files to prepare for multiple translation units Andreas Hindborg
2023-07-04 23:43 ` Damien Le Moal
2023-07-04 16:52 ` [PATCH v5 4/5] ublk: add helper to check if device supports user copy Andreas Hindborg
2023-07-04 23:43 ` Damien Le Moal
2023-07-04 16:52 ` [PATCH v5 5/5] ublk: enable zoned storage support Andreas Hindborg
2023-07-04 22:15 ` kernel test robot
2023-07-05 0:11 ` kernel test robot
2023-07-05 1:00 ` Damien Le Moal
2023-07-05 8:29 ` Andreas Hindborg (Samsung)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230704165209.514591-2-nmi@metaspace.dk \
--to=nmi@metaspace.dk \
--cc=Aravind.Ramesh@wdc.com \
--cc=Hans.Holmberg@wdc.com \
--cc=Matias.Bjorling@wdc.com \
--cc=a.hindborg@samsung.com \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=gost.dev@samsung.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=minwoo.im.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®