From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DADFEC001B0 for ; Wed, 5 Jul 2023 15:51:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232801AbjGEPve (ORCPT ); Wed, 5 Jul 2023 11:51:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232846AbjGEPv2 (ORCPT ); Wed, 5 Jul 2023 11:51:28 -0400 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EF4E1BD5; Wed, 5 Jul 2023 08:51:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:Content-Type:Mime-Version: References:In-Reply-To:Message-Id:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=W3LjWk1kZjcLzuXisEsUj+0kbo+qQeb9JAdNbOz0AXg=; b=U/WLeQxJy6IZEL9Lry1/qgPeQi 6TZF/f6uMvZW9/YgsFE7Ex1ox9OHkWBzmmPbwoD+RF+EZ1E9qa9UJFnvXGKIyLljcotn8L5zG7xWF IA0Yn9UWaegZkrPaWH1WpnMMrtFPWhrUcLAs4yGZDcDA5sTB4hVHDYvKG1yZQX4JFO9I=; Received: from modemcable061.19-161-184.mc.videotron.ca ([184.161.19.61]:45508 helo=pettiford) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1qH4mY-0005Ke-Us; Wed, 05 Jul 2023 11:51:08 -0400 Date: Wed, 5 Jul 2023 11:51:06 -0400 From: Hugo Villeneuve To: Krzysztof Kozlowski Cc: Fabio Estevam , Nate Drude , Pierluigi Passaro , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , Hugo Villeneuve , Krzysztof Kozlowski , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Message-Id: <20230705115106.a4c314e8e177f6516bebda13@hugovil.com> In-Reply-To: <45545984-ef00-f653-91db-cb6c1cb0a3a4@linaro.org> References: <20230704150240.2022020-1-hugo@hugovil.com> <20230704164140.824f6890dae5c87fc92531b4@hugovil.com> <20230704172801.f11422b3f947c625f53af871@hugovil.com> <20230705093507.7458eada3ae05e0e1740a10e@hugovil.com> <20230705102502.d8c9fa894bd271a5526d81f7@hugovil.com> <20230705104837.e620da576f22f28244daacb1@hugovil.com> <20230705113419.183f686f47252abf3532fc9e@hugovil.com> <45545984-ef00-f653-91db-cb6c1cb0a3a4@linaro.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 184.161.19.61 X-SA-Exim-Mail-From: hugo@hugovil.com Subject: Re: [PATCH] arm64: dts: imx8mn-var-som-symphony: fix USB OTG X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 5 Jul 2023 17:44:05 +0200 Krzysztof Kozlowski wrote: > On 05/07/2023 17:34, Hugo Villeneuve wrote: > > On Wed, 5 Jul 2023 12:22:55 -0300 > > Fabio Estevam wrote: > > > >> Hi Hugo, > >> > >> On Wed, Jul 5, 2023 at 11:48 AM Hugo Villeneuve wrote: > >> > >>> Fabio: do we need to support both configurations in the Linux kernel > >>> tree, and if yes how do you propose we do it? > >> > >> I would suggest supporting the new revision only. > > > > Ok, no problem. > > > > If we go back to my original patch, the changes in it, apart from the > > interrupt, are still required to make USB OTG work (at least in host > > mode, so that we can plug a USB key for example). Also looking at the > > latest varigit changes, I have removed the "typec1_con: > > connector" node (tested ok in host mode). I also added comments in the > > DTS about the particular PTN5150 interrupt pin configurations. > > > > Let me know if I can resubmit it, and if so can I leave the interrupt > > property type to IRQ_TYPE_NONE? > > As I wrote, interrupt type cannot be none. What does it even mean "none" > for your case? Hi, I have no idea why Variscite are using this IRQ type of NONE. I can put IRQ_TYPE_EDGE_FALLING since I tested it and it works. Hugo.