From: Paul Cercueil <paul@crapouillou.net>
To: Wolfram Sang <wsa@kernel.org>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Paul Cercueil <paul@crapouillou.net>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: [PATCH 20/23] i2c: s3c2410: Remove #ifdef guards for PM related functions
Date: Wed, 5 Jul 2023 22:45:18 +0200 [thread overview]
Message-ID: <20230705204521.90050-2-paul@crapouillou.net> (raw)
In-Reply-To: <20230705204521.90050-1-paul@crapouillou.net>
Use the new PM macros for the suspend and resume functions to be
automatically dropped by the compiler when CONFIG_PM or
CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards.
This has the advantage of always compiling these functions in,
independently of any Kconfig option. Thanks to that, bugs and other
regressions are subsequently easier to catch.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
---
drivers/i2c/busses/i2c-s3c2410.c | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index 28f0e5c64f32..d23a9e7fcb48 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -1125,7 +1125,6 @@ static void s3c24xx_i2c_remove(struct platform_device *pdev)
i2c_del_adapter(&i2c->adap);
}
-#ifdef CONFIG_PM_SLEEP
static int s3c24xx_i2c_suspend_noirq(struct device *dev)
{
struct s3c24xx_i2c *i2c = dev_get_drvdata(dev);
@@ -1155,26 +1154,19 @@ static int s3c24xx_i2c_resume_noirq(struct device *dev)
return 0;
}
-#endif
-#ifdef CONFIG_PM
static const struct dev_pm_ops s3c24xx_i2c_dev_pm_ops = {
- SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(s3c24xx_i2c_suspend_noirq,
- s3c24xx_i2c_resume_noirq)
+ NOIRQ_SYSTEM_SLEEP_PM_OPS(s3c24xx_i2c_suspend_noirq,
+ s3c24xx_i2c_resume_noirq)
};
-#define S3C24XX_DEV_PM_OPS (&s3c24xx_i2c_dev_pm_ops)
-#else
-#define S3C24XX_DEV_PM_OPS NULL
-#endif
-
static struct platform_driver s3c24xx_i2c_driver = {
.probe = s3c24xx_i2c_probe,
.remove_new = s3c24xx_i2c_remove,
.id_table = s3c24xx_driver_ids,
.driver = {
.name = "s3c-i2c",
- .pm = S3C24XX_DEV_PM_OPS,
+ .pm = pm_sleep_ptr(&s3c24xx_i2c_dev_pm_ops),
.of_match_table = of_match_ptr(s3c24xx_i2c_match),
},
};
--
2.40.1
next prev parent reply other threads:[~2023-07-05 20:49 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 20:42 [PATCH 00/23] i2c: Use new PM macros Paul Cercueil
2023-07-05 20:42 ` [PATCH 01/23] i2c: amd-mp2: Remove #ifdef guards for PM related functions Paul Cercueil
2023-07-06 2:09 ` Jonathan Cameron
2023-07-08 8:42 ` Paul Cercueil
2023-07-05 20:42 ` [PATCH 02/23] i2c: au1550: " Paul Cercueil
2023-07-06 2:10 ` Jonathan Cameron
2023-07-05 20:42 ` [PATCH 03/23] i2c: iproc: " Paul Cercueil
2023-07-06 2:11 ` Jonathan Cameron
2023-07-06 17:01 ` Ray Jui
2023-07-05 20:42 ` [PATCH 04/23] i2c: brcmstb: " Paul Cercueil
2023-07-06 2:12 ` Jonathan Cameron
2023-07-05 20:42 ` [PATCH 05/23] i2c: davinci: " Paul Cercueil
2023-07-06 2:15 ` Jonathan Cameron
2023-07-05 20:42 ` [PATCH 06/23] i2c: designware: " Paul Cercueil
2023-07-06 2:18 ` Jonathan Cameron
2023-07-06 9:11 ` Andy Shevchenko
2023-07-05 20:42 ` [PATCH 07/23] i2c: exynos5: " Paul Cercueil
2023-07-06 2:25 ` Jonathan Cameron
2023-07-05 20:42 ` [PATCH 08/23] i2c: hix5hd2: " Paul Cercueil
2023-07-06 2:27 ` Jonathan Cameron
2023-07-05 20:43 ` [PATCH 09/23] i2c: i801: " Paul Cercueil
2023-07-06 2:28 ` Jonathan Cameron
2023-07-05 20:43 ` [PATCH 10/23] i2c: img-scb: " Paul Cercueil
2023-07-06 2:31 ` Jonathan Cameron
2023-07-08 8:46 ` Paul Cercueil
2023-07-05 20:43 ` [PATCH 11/23] i2c: kempld: " Paul Cercueil
2023-07-06 2:37 ` Jonathan Cameron
2023-07-08 9:13 ` Paul Cercueil
2023-07-05 20:43 ` [PATCH 12/23] i2c: lpc2k: " Paul Cercueil
2023-07-06 2:39 ` Jonathan Cameron
2023-07-05 20:43 ` [PATCH 13/23] i2c: mt65xx: " Paul Cercueil
2023-07-06 2:40 ` Jonathan Cameron
2023-07-05 20:43 ` [PATCH 14/23] i2c: nomadik: " Paul Cercueil
2023-07-06 2:41 ` Jonathan Cameron
2023-07-06 17:12 ` Linus Walleij
2023-07-05 20:43 ` [PATCH 15/23] i2c: ocores: " Paul Cercueil
2023-07-06 2:42 ` Jonathan Cameron
2023-07-05 20:43 ` [PATCH 16/23] i2c: pnx: " Paul Cercueil
2023-07-06 2:49 ` Jonathan Cameron
2023-07-05 20:43 ` [PATCH 17/23] i2c: pxa: " Paul Cercueil
2023-07-06 2:50 ` Jonathan Cameron
2023-07-05 20:43 ` [PATCH 18/23] i2c: qup: " Paul Cercueil
2023-07-06 2:51 ` Jonathan Cameron
2023-07-05 20:45 ` [PATCH 19/23] i2c: rcar: " Paul Cercueil
2023-07-05 20:45 ` Paul Cercueil [this message]
2023-07-06 3:06 ` [PATCH 20/23] i2c: s3c2410: " Jonathan Cameron
2023-07-05 20:45 ` [PATCH 21/23] i2c: sh-mobile: " Paul Cercueil
2023-07-06 3:07 ` Jonathan Cameron
2023-07-10 12:40 ` Geert Uytterhoeven
2023-07-05 20:45 ` [PATCH 22/23] i2c: virtio: " Paul Cercueil
2023-07-06 3:07 ` Jonathan Cameron
2023-07-06 4:27 ` Viresh Kumar
2023-07-05 20:45 ` [PATCH 23/23] i2c: mux: pca954x: " Paul Cercueil
2023-07-06 3:07 ` Jonathan Cameron
2023-07-06 6:31 ` Peter Rosin
2023-07-06 2:52 ` [PATCH 19/23] i2c: rcar: " Jonathan Cameron
2023-07-10 12:41 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230705204521.90050-2-paul@crapouillou.net \
--to=paul@crapouillou.net \
--cc=alim.akhtar@samsung.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®