From: Yangtao Li <frank.li@vivo.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Yangtao Li <frank.li@vivo.com>, linux-kernel@vger.kernel.org
Subject: [PATCH 7/8] nvmem: qfprom: do some cleanup
Date: Thu, 6 Jul 2023 12:05:03 +0800 [thread overview]
Message-ID: <20230706040504.34057-7-frank.li@vivo.com> (raw)
In-Reply-To: <20230706040504.34057-1-frank.li@vivo.com>
Use devm_platform_ioremap_resource() and
devm_platform_get_and_ioremap_resource() to simplify code.
BTW convert to use dev_err_probe() instead of open it.
Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
drivers/nvmem/qfprom.c | 17 +++++------------
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
index c1e893c8a247..14814cba2dd6 100644
--- a/drivers/nvmem/qfprom.c
+++ b/drivers/nvmem/qfprom.c
@@ -374,8 +374,7 @@ static int qfprom_probe(struct platform_device *pdev)
return -ENOMEM;
/* The corrected section is always provided */
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- priv->qfpcorrected = devm_ioremap_resource(dev, res);
+ priv->qfpcorrected = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
if (IS_ERR(priv->qfpcorrected))
return PTR_ERR(priv->qfpcorrected);
@@ -402,12 +401,10 @@ static int qfprom_probe(struct platform_device *pdev)
priv->qfpraw = devm_ioremap_resource(dev, res);
if (IS_ERR(priv->qfpraw))
return PTR_ERR(priv->qfpraw);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 2);
- priv->qfpconf = devm_ioremap_resource(dev, res);
+ priv->qfpconf = devm_platform_ioremap_resource(pdev, 2);
if (IS_ERR(priv->qfpconf))
return PTR_ERR(priv->qfpconf);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 3);
- priv->qfpsecurity = devm_ioremap_resource(dev, res);
+ priv->qfpsecurity = devm_platform_ioremap_resource(pdev, 3);
if (IS_ERR(priv->qfpsecurity))
return PTR_ERR(priv->qfpsecurity);
@@ -427,12 +424,8 @@ static int qfprom_probe(struct platform_device *pdev)
return PTR_ERR(priv->vcc);
priv->secclk = devm_clk_get(dev, "core");
- if (IS_ERR(priv->secclk)) {
- ret = PTR_ERR(priv->secclk);
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "Error getting clock: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(priv->secclk))
+ return dev_err_probe(dev, PTR_ERR(priv->secclk), "Error getting clock\n");
/* Only enable writing if we have SoC data. */
if (priv->soc_data)
--
2.39.0
next prev parent reply other threads:[~2023-07-06 4:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 4:04 [PATCH 1/8] nvmem: sunxi_sid: Convert to devm_platform_ioremap_resource() Yangtao Li
2023-07-06 4:04 ` [PATCH 2/8] nvmem: brcm_nvram: Use devm_platform_get_and_ioremap_resource() Yangtao Li
2023-07-06 4:04 ` [PATCH 3/8] nvmem: lpc18xx_otp: Convert to devm_platform_ioremap_resource() Yangtao Li
2023-07-06 4:05 ` [PATCH 4/8] nvmem: meson-mx-efuse: " Yangtao Li
2023-07-06 4:05 ` [PATCH 5/8] nvmem: rockchip-efuse: Use devm_platform_get_and_ioremap_resource() Yangtao Li
2023-07-11 13:35 ` Heiko Stuebner
2023-07-06 4:05 ` [PATCH 6/8] nvmem: stm32-romem: " Yangtao Li
2023-07-06 4:05 ` Yangtao Li [this message]
2023-07-06 4:05 ` [PATCH 8/8] nvmem: uniphier: " Yangtao Li
2023-07-11 18:26 ` [PATCH 1/8] nvmem: sunxi_sid: Convert to devm_platform_ioremap_resource() Jernej Škrabec
2023-07-13 10:05 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230706040504.34057-7-frank.li@vivo.com \
--to=frank.li@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®