mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yangtao Li <frank.li@vivo.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Yangtao Li <frank.li@vivo.com>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 02/11] media: pxa_camera: Use devm_platform_get_and_ioremap_resource()
Date: Thu,  6 Jul 2023 18:10:50 +0800	[thread overview]
Message-ID: <20230706101100.75654-2-frank.li@vivo.com> (raw)
In-Reply-To: <20230706101100.75654-1-frank.li@vivo.com>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 drivers/media/platform/intel/pxa_camera.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/media/platform/intel/pxa_camera.c b/drivers/media/platform/intel/pxa_camera.c
index 9ed3c2e063de..aaf83e515ff7 100644
--- a/drivers/media/platform/intel/pxa_camera.c
+++ b/drivers/media/platform/intel/pxa_camera.c
@@ -2274,9 +2274,15 @@ static int pxa_camera_probe(struct platform_device *pdev)
 	int irq;
 	int err = 0, i;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	/*
+	 * Request the regions.
+	 */
+	base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
+	if (IS_ERR(base))
+		return PTR_ERR(base);
+
 	irq = platform_get_irq(pdev, 0);
-	if (!res || irq < 0)
+	if (irq < 0)
 		return -ENODEV;
 
 	pcdev = devm_kzalloc(&pdev->dev, sizeof(*pcdev), GFP_KERNEL);
@@ -2338,13 +2344,6 @@ static int pxa_camera_probe(struct platform_device *pdev)
 	spin_lock_init(&pcdev->lock);
 	mutex_init(&pcdev->mlock);
 
-	/*
-	 * Request the regions.
-	 */
-	base = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(base))
-		return PTR_ERR(base);
-
 	pcdev->irq = irq;
 	pcdev->base = base;
 
-- 
2.39.0


  reply	other threads:[~2023-07-06 10:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-06 10:10 [PATCH 01/11] media: atmel-isi: Convert to devm_platform_ioremap_resource() Yangtao Li
2023-07-06 10:10 ` Yangtao Li [this message]
2023-07-06 10:10 ` [PATCH 03/11] media: marvell: Use devm_platform_get_and_ioremap_resource() Yangtao Li
2023-07-06 10:10 ` [PATCH 04/11] media: microchip-sama5d2-isc: Convert to devm_platform_ioremap_resource() Yangtao Li
2023-07-06 10:10 ` [PATCH 05/11] media: fimc-lite: " Yangtao Li
2023-07-06 10:10 ` [PATCH 06/11] media: microchip-sama7g5-isc: " Yangtao Li
2023-07-06 10:10 ` [PATCH 07/11] media: verisilicon: Convert to devm_platform_ioremap_resource() and devm_platform_ioremap_resource_byname() Yangtao Li
2023-07-07  8:26   ` Chen-Yu Tsai
2023-07-06 10:10 ` [PATCH 08/11] media: stm32-dcmi: Use devm_platform_get_and_ioremap_resource() Yangtao Li
2023-07-06 10:10 ` [PATCH 09/11] media: platform: ti: " Yangtao Li
2023-07-07  8:37   ` Laurent Pinchart
2023-07-06 10:10 ` [PATCH 10/11] media: fimc-core: Convert to devm_platform_ioremap_resource() Yangtao Li
2023-07-06 10:10 ` [PATCH 11/11] media: sh_vou: " Yangtao Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230706101100.75654-2-frank.li@vivo.com \
    --to=frank.li@vivo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®