From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08485EB64D9 for ; Thu, 6 Jul 2023 13:37:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231721AbjGFNhU (ORCPT ); Thu, 6 Jul 2023 09:37:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbjGFNhR (ORCPT ); Thu, 6 Jul 2023 09:37:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FDF08F; Thu, 6 Jul 2023 06:37:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B18AE61927; Thu, 6 Jul 2023 13:37:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B445C433C7; Thu, 6 Jul 2023 13:37:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688650635; bh=5xsDFMqKiKcb2GYFWhTiN6rPXWfblS1mUzchy+w1xDg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RHrvdu5Uj7cAqAyDgp0i5NO1d8iIZP9KrKs2nGX87TOW7L5pO4fpt1/GpPgyTV6aI GuNNMZZ5QP/NFhmWGJz9vC2vQnwH/aE5etRMn2rz+k29zxN7Jmrv/1n5JabfAimgwE CblqGpIpi3ygL9ulgfcLzFP0fdwmUjQxIYkC7TLk5mhj86sm7GbDB6+xlYBglN7VXm X/6qrbSTTZm+YBaRihpPMhj0wF2duhBvSLXqDcolrZoSOR2h2kKJXh1G7rPHXWgVOm 9jS6KILvLkbUyqkH2xqejWrAdh0ikBNpPl/5Z0DFxgXEUMHp/vDNO0XVe8BYjLweyY xC91EDHU0UTDA== Date: Thu, 6 Jul 2023 22:37:10 +0900 From: Masami Hiramatsu (Google) To: Li zeming Cc: naveen.n.rao@linux.ibm.com, anil.s.keshavamurthy@intel.com, davem@davemloft.net, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH] kprobes: Remove unnecessary =?UTF-8?B?4oCYMOKAmQ==?= values from ret Message-Id: <20230706223710.58284736311727766cee345a@kernel.org> In-Reply-To: <20230704192107.2944-1-zeming@nfschina.com> References: <20230704192107.2944-1-zeming@nfschina.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 5 Jul 2023 03:21:07 +0800 Li zeming wrote: > ret is assigned first, so it does not need to initialize the assignment. > > Signed-off-by: Li zeming Looks good to me. Acked-by: Masami Hiramatsu (Google) Thank you! > --- > kernel/kprobes.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/kprobes.c b/kernel/kprobes.c > index 00e177de91cc..db8a3aa53cf6 100644 > --- a/kernel/kprobes.c > +++ b/kernel/kprobes.c > @@ -1072,7 +1072,7 @@ static int kprobe_ftrace_enabled; > static int __arm_kprobe_ftrace(struct kprobe *p, struct ftrace_ops *ops, > int *cnt) > { > - int ret = 0; > + int ret; > > lockdep_assert_held(&kprobe_mutex); > > @@ -1110,7 +1110,7 @@ static int arm_kprobe_ftrace(struct kprobe *p) > static int __disarm_kprobe_ftrace(struct kprobe *p, struct ftrace_ops *ops, > int *cnt) > { > - int ret = 0; > + int ret; > > lockdep_assert_held(&kprobe_mutex); > > -- > 2.18.2 > -- Masami Hiramatsu (Google)