From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A911C001B0 for ; Fri, 7 Jul 2023 21:05:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232533AbjGGVF5 (ORCPT ); Fri, 7 Jul 2023 17:05:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232377AbjGGVFz (ORCPT ); Fri, 7 Jul 2023 17:05:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2F6A1BD2 for ; Fri, 7 Jul 2023 14:05:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 34CED61A66 for ; Fri, 7 Jul 2023 21:05:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BC7FC433C9; Fri, 7 Jul 2023 21:05:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1688763953; bh=wIbc8HTUUZfRvfDpoEteNIK4JDXCZ1at/pNiozS117k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=z/5k/i7fxqVHgVojMa++l/xaXfNe7dqYCBfHSWAwn5Vvom1hVKoyeOGgvh6Fcejjn fjbvugBxpSZwlu5VfZvPb6BcOFzrkKMjmwC/vcygGF2P4J3nC1wdSDfoGf3u2M/Vga BNyvpHeP6+4+y2oNjNGrC40yJNDGdMgQ+0UZFSMM= Date: Fri, 7 Jul 2023 14:05:51 -0700 From: Andrew Morton To: Matthew Wilcox Cc: Jiaqi Yan , mike.kravetz@oracle.com, naoya.horiguchi@nec.com, songmuchun@bytedance.com, shy828301@gmail.com, linmiaohe@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, duenwen@google.com, axelrasmussen@google.com, jthoughton@google.com Subject: Re: [PATCH v3 2/4] mm/hwpoison: check if a subpage of a hugetlb folio is raw HWPOISON Message-Id: <20230707140551.07e06293e4943be0c6c557fe@linux-foundation.org> In-Reply-To: References: <20230707201904.953262-1-jiaqiyan@google.com> <20230707201904.953262-3-jiaqiyan@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 7 Jul 2023 21:31:39 +0100 Matthew Wilcox wrote: > On Fri, Jul 07, 2023 at 08:19:02PM +0000, Jiaqi Yan wrote: > > Add the functionality, is_raw_hwp_subpage, to tell if a subpage of a > > This is incorrect naming. "subpage" was needed before we had the > folio concept, but it should not be used any more. We have folios > and pages now. > > Also, abbreviating "hwpoison" as "hwp" seems like a bad idea to me. > hwp is already used as an acronym by acpi, intel_pstate, some clock > drivers, an ethernet driver, and a scsi driver. Thanks, Matthew. I'll merge v3 so we hit next -next (which actually won't be until Monday), and add a note that v4 is expected.