From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF840EB64D9 for ; Mon, 10 Jul 2023 08:05:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232465AbjGJIFt (ORCPT ); Mon, 10 Jul 2023 04:05:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232211AbjGJIFr (ORCPT ); Mon, 10 Jul 2023 04:05:47 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 402A2100 for ; Mon, 10 Jul 2023 01:05:41 -0700 (PDT) Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id C62571EC0622; Mon, 10 Jul 2023 10:05:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1688976339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=PKMVLHHTljB+aZKz/kMixqd9D2fBGzHr1sfuZuXFjGU=; b=RQOnRcDtgWAzCrw+tEPE5SZ6bjYrrfiU12DMy6fqc4mcNDHmjt9xql5e+J6XW48Jhd57BY sAodBYyu8J8Wnb40vnAJS23WkX5f1snH7txMC+S90wt1f7y7qhKTLvfNg/yoo1X3hGA1hL llh8wqk9I/gNuC59xa8WnIpe+J46dT4= X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id TxrFKHtT6B2t; Mon, 10 Jul 2023 08:05:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1688976336; bh=PKMVLHHTljB+aZKz/kMixqd9D2fBGzHr1sfuZuXFjGU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lt/bvoGC2ELpTZkcrWi4sDb181XGuUdlZ2qkNkFVZF9HFmMq5a/I0dI8yz5cRAkdc lsHk/VC/a1g4+dpLE5eokpA54BwHZeNo5m6GT3wPTZBsItz/FtRliL3LH96kimTy1g sBoK/AlYB+a/9i5x03co3axmNCrMiOwXl8WaaXnpNPKNbReo0VwHzL1RFPtpkLxMJU x4SnBq1oDCbdRnavmTaD0K62fB6ia2dtWEs8uMn3BNmwLUZsAnXU+GeCLUUX8yv9gZ Y0rB8ZjO8n2bwVmb4DOAHb7TLZThjVW4prGfqrkNgOi9qUZRNH+mrlYU2LFqU57XkC NlvR/4gH3g61ctE+r/sMnTy2CL1UFgxz/dU+ZL6bJ/jg0PkLj04+jyPdoaDlo1v+jj 6fTu1G5oBU0p3fVvG59vrLvZNfwN8kCHUsiF10IAZYvW8V2BWkVutxG+19nNtOacNg uXwS4OyyUNrrMSG8wWz6ASr5mtjyKdDC1cF+YJhi6XKMUmsKFdWKPbKm1W8RQJ+xka uOFOF/oMuUIX+Shf6OgFaC1lRt8f9wCsMO5+o8HNwaTci1dp8KPga0TKx6HSRywzvo GCvKNJM0+yh8suIgRHaFShGDJrveibT2QePA0WAdqx7H22ds7X194oadfufz06LVEW CdXxDmBROZ/JzHxfSMo7kyn4= Received: from zn.tnic (pd9530d32.dip0.t-ipconnect.de [217.83.13.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id D5E4E40E00F4; Mon, 10 Jul 2023 08:05:24 +0000 (UTC) Date: Mon, 10 Jul 2023 10:05:19 +0200 From: Borislav Petkov To: Dave Hansen Cc: Janusz Krzysztofik , x86@kernel.org, Thomas Gleixner , Ingo Molnar , Juergen Gross , Andi Shyti , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , "Edgecombe, Rick P" , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org Subject: Re: [PATCH v3 RESEND] x86/mm: Fix PAT bit missing from page protection modify mask Message-ID: <20230710080519.GAZKu7v2N/eK/jYXPL@fat_crate.local> References: <20230710073613.8006-2-janusz.krzysztofik@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230710073613.8006-2-janusz.krzysztofik@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 10, 2023 at 09:36:14AM +0200, Janusz Krzysztofik wrote: > Assume that adding _PAGE_PAT to _PAGE_CHG_MASK doesn't break pte_modify() > and its users, and go for it. Also, add _PAGE_PAT_LARGE to That's my only worry. I'd suggest we queue this but not send it to Linus now. Instead, let it cook in linux-next for the whole 6.5 release cycle so that it can get at least *some* testing. Because if we send it now and something else obscure breaks in a weird way in his tree, then we'll have to scramble to fix that too and it'll be one helluva mess. Dave? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette